Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: ChuyuTeam.DISM++ version 10.1.2000.0 #204566

Conversation

ovsky
Copy link

@ovsky ovsky commented Jan 1, 2025

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 1, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) January 1, 2025 15:02
InstallerType: portable
Installers:
- Architecture: x64
InstallerUrl: https://github.com/ovsky/DISM--winget-package/releases/download/10.1.2000.0-x64-x86/DISM++.10.1.2000.0-x64-x86.exe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem like an official URL from the ChuyuTeam. Only official URLs are supported

https://github.com/Chuyu-Team/Dism-Multi-language

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's their official repository, with the latest builds.
They also shared it on the official team website:
https://chuyu.me/en-US/

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@Trenly Trenly Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ovsky - I'm saying that the installer URL is pointing to your own repo and not the official one. In order for us to accept the package, it should be pointing to the official repository, not your own rehosting of the binary

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trenly okay, but their do not provide the installer. I previously tried to send the binary wit required files, but another WinGet mod - in previous PR - told me to pack it and upload an installer.

image

If not this way either, how can I put the DISM++ on the winget repository?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or do you mean that it is enough that the URL points to the correct repository and everything else is fine?

Copy link
Contributor

@Trenly Trenly Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern is that then you have modified it, and it wouldn’t be the official Chuyu Team distribution still. You could call it ovsky.DISM++, since then it isn't claiming to be a package officially provided by Chuyu Team

However, an installer should not technically be required. I looked at what is in the zip file, and it should be perfectly fine to specify it as -

- InstallerType: zip
  NestedInstallerType: portable
  ArchiveBinariesDependOnPath: true
  Architecture:
  InstallerUrl:

If that doesn't work, then I'm not sure

Copy link
Contributor

@Trenly Trenly Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

@ovsky ovsky Jan 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trenly thank you very much for all your help and as well pushing DISM++ to winget repository by yourself! It will be really helpful for every person using it for debloating and adjusting Windows.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 2, 2025
@stephengillie stephengillie removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 2, 2025
@ovsky ovsky disabled auto-merge January 4, 2025 10:38
@ovsky ovsky closed this Jan 4, 2025
@ovsky ovsky deleted the ChuyuTeam.DISM++-10.1.2000.0-78d59e53-bb0c-448e-83e9-ab4b0c926c5c branch January 4, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Changes-Requested Changes Requested New-Package Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants