-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: ChuyuTeam.DISM++ version 10.1.2000.0 #204566
New package: ChuyuTeam.DISM++ version 10.1.2000.0 #204566
Conversation
/AzurePipelines run |
InstallerType: portable | ||
Installers: | ||
- Architecture: x64 | ||
InstallerUrl: https://github.com/ovsky/DISM--winget-package/releases/download/10.1.2000.0-x64-x86/DISM++.10.1.2000.0-x64-x86.exe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem like an official URL from the ChuyuTeam. Only official URLs are supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's their official repository, with the latest builds.
They also shared it on the official team website:
https://chuyu.me/en-US/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ovsky - I'm saying that the installer URL is pointing to your own repo and not the official one. In order for us to accept the package, it should be pointing to the official repository, not your own rehosting of the binary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Trenly okay, but their do not provide the installer. I previously tried to send the binary wit required files, but another WinGet mod - in previous PR - told me to pack it and upload an installer.
If not this way either, how can I put the DISM++ on the winget repository?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or do you mean that it is enough that the URL points to the correct repository and everything else is fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concern is that then you have modified it, and it wouldn’t be the official Chuyu Team distribution still. You could call it ovsky.DISM++
, since then it isn't claiming to be a package officially provided by Chuyu Team
However, an installer should not technically be required. I looked at what is in the zip file, and it should be perfectly fine to specify it as -
- InstallerType: zip
NestedInstallerType: portable
ArchiveBinariesDependOnPath: true
Architecture:
InstallerUrl:
If that doesn't work, then I'm not sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Trenly thank you very much for all your help and as well pushing DISM++ to winget repository by yourself! It will be really helpful for every person using it for debloating and adjusting Windows.
Checklist for Pull Requests
Manifests
winget validate --manifest <path>
?winget install --manifest <path>
?Note:
<path>
is the directory's name containing the manifest you're submitting.Microsoft Reviewers: Open in CodeFlow