Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to search lambda breakpoint for both chained and multiline lambdas #529

Closed
wants to merge 2 commits into from
Closed

Be able to search lambda breakpoint for both chained and multiline lambdas #529

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
011b33c
Be able to search lambda breakpoint for both chained and multiline la…
testforstephen Dec 11, 2023
c2a47bf
Merge branch 'main' into jinbo_lambda
testforstephen Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...t.java.debug.plugin/src/main/java/com/microsoft/java/debug/BreakpointLocationLocator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ public BreakpointLocationLocator(CompilationUnit compilationUnit, int lineNumber
super(compilationUnit, lineNumber, bindingsResolved, bestMatch);
}

public BreakpointLocationLocator(CompilationUnit compilationUnit, int lineNumber, boolean bindingsResolved,
boolean bestMatch, int offset, int end) {
super(compilationUnit, lineNumber, bindingsResolved, bestMatch, offset, end);
}

@Override
public boolean visit(MethodDeclaration node) {
boolean result = super.visit(node);
Expand Down
2 changes: 1 addition & 1 deletion ...lugin/src/main/java/com/microsoft/java/debug/plugin/internal/JdtSourceLookUpProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ public JavaBreakpointLocation[] getBreakpointLocations(String sourceUri, SourceB
// In future, we could consider supporting to update the breakpoint to a valid
// location.
BreakpointLocationLocator locator = new BreakpointLocationLocator(astUnit,
sourceLine, true, true);
sourceLine, true, true, astUnit.getPosition(sourceLine, 0), 0);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a limitation of the upstream ValidBreakpointLocationLocator. It requires the selection offset to search for line breakpoints on nested chained or multiline lambdas.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the JDT PR eclipse-jdt/eclipse.jdt.debug@5155869#diff-cc2898c3d3963bc7a2093c82575beee0b8b6b3cbf3bd36f38dc46a32d56fb322 for lambda breakpoint support.

astUnit.accept(locator);
// When the final valid line location is same as the original line, that
// represents it's a valid breakpoint.
Expand Down
Loading