Be able to search lambda breakpoint for both chained and multiline lambdas #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
testforstephen
commented
Dec 11, 2023
testforstephen
commented
- Fixes Breakpoint with inline lambdas work only with last one vscode-java-debug#1410
- Fixes [Critical] Cannot debug multiline nested method expression's lambda statements #521
testforstephen
commented
Dec 11, 2023
| @@ -211,7 +211,7 @@ public JavaBreakpointLocation[] getBreakpointLocations(String sourceUri, SourceB | |||
| // In future, we could consider supporting to update the breakpoint to a valid | |||
| // location. | |||
| BreakpointLocationLocator locator = new BreakpointLocationLocator(astUnit, | |||
| sourceLine, true, true); | |||
| sourceLine, true, true, astUnit.getPosition(sourceLine, 0), 0); | |||
There was a problem hiding this comment.
This is a limitation of the upstream ValidBreakpointLocationLocator. It requires the selection offset to search for line breakpoints on nested chained or multiline lambdas.
There was a problem hiding this comment.
See the JDT PR eclipse-jdt/eclipse.jdt.debug@5155869#diff-cc2898c3d3963bc7a2093c82575beee0b8b6b3cbf3bd36f38dc46a32d56fb322 for lambda breakpoint support.
|
superseded by #522 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.