Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): adds load and state cli options #502
feat(cli): adds load and state cli options #502
Changes from 16 commits
351bd55
1c63a5e
b0f9c97
0f2c0ec
0b100b3
0154df9
26f9746
4bbb1a1
2e02e72
d321cca
9c0e73d
71b15bc
6e7b2b5
58b0ccf
c3307c3
2d28463
fee9928
9fbd62e
5eb3c39
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I have feeling this might lead to some unexpected behaviour because that block might technically not be sealed in that batch yet (this is what
l1BatchNumber == null
means). But anyway, the whole forking logic needs some rethinking in general so I am fine with keeping as isSome generated files are not rendered by default. Learn more about how customized files appear on GitHub.