-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): adds load and state cli options #502
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
351bd55
wip
dutterbutter 1c63a5e
feat: adds dump state option to cli with test
dutterbutter b0f9c97
chore: clean up and cargo fmt
dutterbutter 0f2c0ec
chore: remove unneeded pub
dutterbutter 0b100b3
chore: clean up and cargo fmt
dutterbutter 0154df9
chore: add e2e tst for dump_state, update alloy-zksync to latest
dutterbutter 26f9746
chore: clean up, lint, move write_json to utils, resolve conflicts, u…
dutterbutter 4bbb1a1
feat: adds load and state cli options
dutterbutter 2e02e72
fix: batch number null issue
dutterbutter d321cca
chore: make requested changes
dutterbutter 9c0e73d
chore: clean up and cargo fmt
dutterbutter 71b15bc
run cargo fmt
dutterbutter 6e7b2b5
chore: clean up and cargo fmt
dutterbutter 58b0ccf
chore: resolve conflicts
dutterbutter c3307c3
chore: remove fork tests for now
dutterbutter 2d28463
Merge branch 'main' into db/adds-load-state-cli-option
dutterbutter fee9928
chore: remove uneeded dep
dutterbutter 9fbd62e
Merge branch 'db/adds-load-state-cli-option' of github.com:matter-lab…
dutterbutter 5eb3c39
Merge branch 'main' into db/adds-load-state-cli-option
dutterbutter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I have feeling this might lead to some unexpected behaviour because that block might technically not be sealed in that batch yet (this is what
l1BatchNumber == null
means). But anyway, the whole forking logic needs some rethinking in general so I am fine with keeping as is