Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version of tools installed by pip #1242

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

Fix version of tools installed by pip #1242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/autoit-ripper.vm/autoit-ripper.vm.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<package xmlns="http://schemas.microsoft.com/packaging/2015/06/nuspec.xsd">
<metadata>
<id>autoit-ripper.vm</id>
<version>0.0.0.20240607</version>
<version>1.1.2</version>
<authors>Michał Praszmo</authors>
<description>Extracts compiled AutoIt scripts from PE executables.</description>
<dependencies>
Expand Down
1 change: 1 addition & 0 deletions packages/autoit-ripper.vm/tools/chocolateyinstall.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@ Import-Module vm.common -Force -DisableNameChecking

$toolName = 'autoit-ripper'
$category = 'Packers'
$version = '==1.1.2'

VM-Install-With-Pip -toolName $toolName -category $category
2 changes: 1 addition & 1 deletion packages/common.vm/tools/vm.common/vm.common.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1761,7 +1761,7 @@ function VM-Install-With-Pip {
[string] $toolName, # Example: magika
[Parameter(Mandatory=$true)]
[string] $category,
[Parameter(Mandatory=$false)]
[Parameter(Mandatory=$true)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the common nuspec also needs update. Please run the linter locally or check the CI status after sending the changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause a conflict with #1243 which also updates common. As the other PR has more changes (and is more difficult to rebase), I suggest you wait to do this change after that PR has been merged, to avoid the merge conflicts.

[string] $version = "", # Version using pip format, example: "==0.5.0"
[Parameter(Mandatory=$false)]
[string] $arguments = "--help"
Expand Down
2 changes: 1 addition & 1 deletion packages/ipython.vm/ipython.vm.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<package xmlns="http://schemas.microsoft.com/packaging/2015/06/nuspec.xsd">
<metadata>
<id>ipython.vm</id>
<version>8.27.0.20241001</version>
<version>8.27.0</version>
<authors>Fernando Perez</authors>
<description>A powerful interactive Python shell</description>
<dependencies>
Expand Down
1 change: 1 addition & 0 deletions packages/ipython.vm/tools/chocolateyinstall.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@ Import-Module vm.common -Force -DisableNameChecking

$toolName = 'ipython'
$category = 'Productivity Tools'
$version = '==8.27.0'

VM-Install-With-Pip -toolName $toolName -category $category -arguments ""
Loading