Fix version of tools installed by pip #1242
Conversation
There was a problem hiding this comment.
Thanks for adding the versions @sara-rn!! 💐 As noticed by the linter, you have forgotten to update the version in the ipython.vm nuspec. Also, ensure to follow good commit practices such as limiting the subject line to 50 characters and using the body to explain what and why you make the changes. I recommend reading https://cbea.ms/git-commit for more info on best practices to write good commit messages. 😉
sara-rn
force-pushed
the
version_pip_tools
branch
from
27b6ab9 to
0b4e293
Compare
| @@ -1761,7 +1761,7 @@ function VM-Install-With-Pip { | |||
| [string] $toolName, # Example: magika | |||
| [Parameter(Mandatory=$true)] | |||
| [string] $category, | |||
| [Parameter(Mandatory=$false)] | |||
| [Parameter(Mandatory=$true)] | |||
There was a problem hiding this comment.
the common nuspec also needs update. Please run the linter locally or check the CI status after sending the changes.
There was a problem hiding this comment.
This will cause a conflict with #1243 which also updates common. As the other PR has more changes (and is more difficult to rebase), I suggest you wait to do this change after that PR has been merged, to avoid the merge conflicts.
Closes #1240
Change the version parameter to required and change tools installed with PIP to include the version