-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Map for rule search and add benchmark #334
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The benchmark script now runs the suite both for the local version of the source code and v1.13.0, which is fetched from a CDN.
This avoids having to iterate over all the rules to parse them first and then again to build the map. It also simplifies implementation by not expecting more than one rule for a given punySuffix.
Merged
mfdebian
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Amazing To Me ⭐
I guess I don't really have much to add, sadly, but I ran it, tried some edge cases and it works like a charm ✨
Literally a HUGE improvement in terms of complexity 👏
Thanks for the review @mfdebian 💛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the changes proposed by @gugu's in #302 as well as on other minor tweaks (like only iterating over the rules once instead of twice on module load).
This increases performance (ops/sec) by a factor of over 100!!
The main change is using a
Map
object and indexing it bypunySuffix
. This allows searching bypunySuffix
without having to iterate over the thousands of rules.