use maps for rule search, add benchmark #302
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
There are 9000 rules and to check domain validity we need to iterate over them. It is hard to use map because we need to search by substring, performance
O(domainsCount * ruleCount)
Solution:
O(ruleCount)
suffix => [rule1, rule2, ..]
, which usually has 1 elementO(ruleCount)
O(1)
E.g. for mysubdomain.google.co.uk:
Fixes #301