Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 New Crowdin updates #1507

Merged
merged 101 commits into from
Jan 22, 2025
Merged

🌐 New Crowdin updates #1507

merged 101 commits into from
Jan 22, 2025

Conversation

lukevella
Copy link
Owner

@lukevella lukevella commented Jan 21, 2025

Summary by CodeRabbit

Release Notes

  • Localization Updates

    • Removed self-hosting references from multiple language home pages.
    • Added new localization strings for email verification and registration, including prompts for confirming email changes.
    • Introduced "Start for free" pricing titles across various languages.
    • Updated various localization strings to enhance clarity around user actions and processes.
  • Web Application

    • Simplified user registration and login messaging.
    • Enhanced email verification process.
    • Removed guest login options.
  • Landing Page

    • Updated meta descriptions and localization content.
    • Removed references to self-hosting capabilities.
    • Added new pricing titles and subtitles for clarity on premium features.

Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
app ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 5:59pm
landing ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 5:59pm

@vercel vercel bot temporarily deployed to Preview – landing January 21, 2025 18:40 Inactive
Copy link
Contributor

coderabbitai bot commented Jan 21, 2025

Walkthrough

This pull request involves comprehensive updates to localization files across multiple languages for both web application and landing page interfaces. The changes primarily focus on modifying user registration, login, and email verification strings. Key modifications include removing outdated registration prompts, adding new email verification messages, and introducing more concise descriptions for user actions. These updates aim to streamline user experience and provide clearer guidance during account management processes.

Changes

Files Change Summary
apps/web/public/locales/*/app.json Removed: "alreadyRegistered", "loginWith", "continueAsGuest" strings.
Added: "userNotFound", "verifyEmail", "registerDescription", "savePercentage".
apps/landing/public/locales/*/home.json Removed: "selfHostingBlog" entries across all languages.
apps/landing/public/locales/*/pricing.json Added: "pricingTitle" with localized "Start for free" variations.
packages/emails/locales/*/emails.json Added: "changeEmailRequest_preview" for email verification.

Possibly related PRs

  • 🌐 New Crowdin updates #1091: Changes in localization strings for various languages, including the removal of "alreadyRegistered" and "loginWith," which are also present in the main PR.
  • 🌐 New Crowdin updates #1096: Similar updates to localization files, including the removal of "alreadyRegistered" and "loginWith," indicating a related focus on user registration prompts.
  • 🌐 New Crowdin updates #1103: Updates to localization files that include the removal of similar user prompts, aligning with the changes in the main PR.

Poem

🐰 A Localization Hop! 🌍
In languages near and far,
We've trimmed the text, raised the bar!
No more "guest" or "already here",
Just clear messages, crystal clear!
Rallly's words now dance with grace,
A multilingual embrace! 🌈


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f5ab25e and 165f80f.

📒 Files selected for processing (25)
  • apps/web/public/locales/ca/app.json (1 hunks)
  • apps/web/public/locales/cs/app.json (1 hunks)
  • apps/web/public/locales/da/app.json (1 hunks)
  • apps/web/public/locales/de/app.json (1 hunks)
  • apps/web/public/locales/en/app.json (1 hunks)
  • apps/web/public/locales/es/app.json (1 hunks)
  • apps/web/public/locales/eu/app.json (1 hunks)
  • apps/web/public/locales/fi/app.json (1 hunks)
  • apps/web/public/locales/fr/app.json (1 hunks)
  • apps/web/public/locales/hr/app.json (1 hunks)
  • apps/web/public/locales/hu/app.json (1 hunks)
  • apps/web/public/locales/it/app.json (1 hunks)
  • apps/web/public/locales/ja/app.json (1 hunks)
  • apps/web/public/locales/ko/app.json (1 hunks)
  • apps/web/public/locales/nl/app.json (1 hunks)
  • apps/web/public/locales/no/app.json (1 hunks)
  • apps/web/public/locales/pl/app.json (1 hunks)
  • apps/web/public/locales/pt-BR/app.json (1 hunks)
  • apps/web/public/locales/pt/app.json (1 hunks)
  • apps/web/public/locales/ru/app.json (1 hunks)
  • apps/web/public/locales/sk/app.json (1 hunks)
  • apps/web/public/locales/sv/app.json (1 hunks)
  • apps/web/public/locales/tr/app.json (1 hunks)
  • apps/web/public/locales/zh-Hant/app.json (1 hunks)
  • apps/web/public/locales/zh/app.json (1 hunks)
🔇 Additional comments (24)
apps/web/public/locales/zh-Hant/app.json (1)

267-268: LGTM! Traditional Chinese translations are accurate.

The translations for "subscribe" and "userNotFound" are grammatically correct and maintain proper Traditional Chinese characters.

apps/web/public/locales/ja/app.json (1)

272-273: LGTM! Japanese translations are accurate and natural.

The translations for "cancelAnytime" and "userNotFound" are grammatically correct and maintain proper Japanese language conventions. The HTML tag is also correctly preserved.

apps/web/public/locales/ko/app.json (1)

272-273: LGTM! Korean translations are accurate and natural.

The translations for "cancelAnytime" and "userNotFound" are grammatically correct and maintain proper Korean language conventions. The HTML tag is also correctly preserved.

apps/web/public/locales/sk/app.json (1)

254-255: LGTM! Slovak translations are accurate and natural.

The translations for "annualBenefit" and "userNotFound" are grammatically correct and maintain proper Slovak language conventions. The placeholder is also correctly preserved.

apps/web/public/locales/hr/app.json (1)

254-255: LGTM! The Croatian translations are accurate.

The translations maintain proper grammar and preserve the required placeholders. The messaging is clear and consistent with other language files.

apps/web/public/locales/pt/app.json (1)

254-255: LGTM! The Portuguese translations are accurate.

The translations maintain proper grammar and preserve the required placeholders. The messaging is clear and consistent with other language files.

apps/web/public/locales/it/app.json (1)

253-254: LGTM! The Italian translations are accurate.

The translations maintain proper grammar and preserve the required placeholders. The messaging is clear and consistent with other language files.

apps/web/public/locales/cs/app.json (1)

265-266: LGTM! The Czech translations are accurate.

The translations maintain proper grammar and the messaging is clear and consistent with other language files.

apps/web/public/locales/ca/app.json (1)

254-255: LGTM! The Catalan translations are accurate.

The translations maintain proper grammar and preserve the required placeholders. The messaging is clear and consistent with other language files.

apps/web/public/locales/sv/app.json (1)

268-269: LGTM! Swedish translations are accurate.

The added translations for "subscribe" and "userNotFound" are grammatically correct and maintain consistency with the English meaning.

apps/web/public/locales/fi/app.json (1)

272-273: LGTM! Finnish translations are accurate.

The added translations for "cancelAnytime" and "userNotFound" are grammatically correct and maintain consistency with the English meaning. The HTML link tag is properly preserved in the "cancelAnytime" string.

apps/web/public/locales/da/app.json (1)

272-273: LGTM! Danish translations are accurate.

The added translations for "cancelAnytime" and "userNotFound" are grammatically correct and maintain consistency with the English meaning. The HTML link tag is properly preserved in the "cancelAnytime" string.

apps/web/public/locales/tr/app.json (1)

272-273: LGTM! Turkish translations are accurate.

The added translations for "cancelAnytime" and "userNotFound" are grammatically correct and maintain consistency with the English meaning. The HTML link tag is properly preserved in the "cancelAnytime" string.

apps/web/public/locales/pl/app.json (1)

272-273: LGTM! Polish translations are accurate.

The added translations for "cancelAnytime" and "userNotFound" are grammatically correct and maintain consistency with the English meaning. The HTML link tag is properly preserved in the "cancelAnytime" string.

apps/web/public/locales/eu/app.json (1)

272-273: LGTM! Translations are accurate and well-formatted.

The Basque translations maintain proper HTML formatting and follow correct grammatical structure.

apps/web/public/locales/no/app.json (1)

272-273: LGTM! Translations are accurate and well-formatted.

The Norwegian translations maintain proper HTML formatting and follow correct grammatical structure.

apps/web/public/locales/fr/app.json (1)

272-273: LGTM! Translations are accurate and well-formatted.

The French translations maintain proper HTML formatting and follow correct grammatical structure.

apps/web/public/locales/hu/app.json (1)

285-285: LGTM! Translation is accurate.

The Hungarian translation for "userNotFound" follows correct grammatical structure.

apps/web/public/locales/nl/app.json (1)

284-285: LGTM! Translations are accurate and well-formatted.

The Dutch translations follow correct grammatical structure and maintain proper punctuation.

apps/web/public/locales/pt-BR/app.json (1)

284-285: LGTM! Portuguese (Brazil) translations are accurate.

The new translations for "emailAlreadyInUse" and "userNotFound" are grammatically correct and maintain consistency with Brazilian Portuguese language conventions.

apps/web/public/locales/ru/app.json (1)

284-285: LGTM! Russian translations are accurate.

The new translations for "emailAlreadyInUse" and "userNotFound" are grammatically correct and follow proper Russian language conventions.

apps/web/public/locales/en/app.json (1)

284-309: LGTM! English strings are well-structured and complete.

The new strings maintain consistent naming conventions, proper placeholder usage, and correct HTML tag formatting. The messages are clear and maintain a consistent tone throughout.

apps/web/public/locales/es/app.json (1)

284-285: LGTM! Spanish translations are accurate.

The new translations for "emailAlreadyInUse" and "userNotFound" are grammatically correct and maintain consistency with Spanish language conventions.

apps/web/public/locales/de/app.json (1)

284-285: LGTM! German translations are accurate.

The new translations for "emailAlreadyInUse" and "userNotFound" are grammatically correct and maintain consistency with German language conventions.

apps/web/public/locales/zh/app.json Outdated Show resolved Hide resolved
apps/web/public/locales/hu/app.json Outdated Show resolved Hide resolved
Copy link

vercel bot commented Jan 21, 2025

Deployment failed with the following error:

Too many requests - try again in 2 minutes (more than 120, code: "api-deployments-flood-pro").

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 165f80f and 7fe23af.

📒 Files selected for processing (60)
  • apps/landing/public/locales/ca/home.json (1 hunks)
  • apps/landing/public/locales/ca/pricing.json (1 hunks)
  • apps/landing/public/locales/cs/home.json (1 hunks)
  • apps/landing/public/locales/cs/pricing.json (1 hunks)
  • apps/landing/public/locales/da/home.json (0 hunks)
  • apps/landing/public/locales/de/home.json (0 hunks)
  • apps/landing/public/locales/es/home.json (0 hunks)
  • apps/landing/public/locales/eu/home.json (0 hunks)
  • apps/landing/public/locales/fi/home.json (1 hunks)
  • apps/landing/public/locales/fr/home.json (0 hunks)
  • apps/landing/public/locales/hr/home.json (1 hunks)
  • apps/landing/public/locales/hr/pricing.json (1 hunks)
  • apps/landing/public/locales/hu/home.json (1 hunks)
  • apps/landing/public/locales/it/home.json (1 hunks)
  • apps/landing/public/locales/it/pricing.json (1 hunks)
  • apps/landing/public/locales/ja/home.json (0 hunks)
  • apps/landing/public/locales/ko/home.json (0 hunks)
  • apps/landing/public/locales/nl/home.json (0 hunks)
  • apps/landing/public/locales/no/home.json (0 hunks)
  • apps/landing/public/locales/pl/home.json (0 hunks)
  • apps/landing/public/locales/pt-BR/home.json (0 hunks)
  • apps/landing/public/locales/pt/home.json (1 hunks)
  • apps/landing/public/locales/ru/home.json (0 hunks)
  • apps/landing/public/locales/sk/home.json (1 hunks)
  • apps/landing/public/locales/sk/pricing.json (1 hunks)
  • apps/landing/public/locales/sv/home.json (1 hunks)
  • apps/landing/public/locales/tr/home.json (1 hunks)
  • apps/landing/public/locales/tr/pricing.json (1 hunks)
  • apps/landing/public/locales/zh-Hant/home.json (1 hunks)
  • apps/landing/public/locales/zh/home.json (0 hunks)
  • apps/web/public/locales/ca/app.json (1 hunks)
  • apps/web/public/locales/cs/app.json (2 hunks)
  • apps/web/public/locales/da/app.json (1 hunks)
  • apps/web/public/locales/de/app.json (1 hunks)
  • apps/web/public/locales/es/app.json (1 hunks)
  • apps/web/public/locales/eu/app.json (1 hunks)
  • apps/web/public/locales/fi/app.json (1 hunks)
  • apps/web/public/locales/fr/app.json (1 hunks)
  • apps/web/public/locales/hr/app.json (1 hunks)
  • apps/web/public/locales/hu/app.json (1 hunks)
  • apps/web/public/locales/it/app.json (2 hunks)
  • apps/web/public/locales/ja/app.json (1 hunks)
  • apps/web/public/locales/ko/app.json (1 hunks)
  • apps/web/public/locales/nl/app.json (1 hunks)
  • apps/web/public/locales/no/app.json (1 hunks)
  • apps/web/public/locales/pl/app.json (1 hunks)
  • apps/web/public/locales/pt-BR/app.json (1 hunks)
  • apps/web/public/locales/pt/app.json (1 hunks)
  • apps/web/public/locales/ru/app.json (1 hunks)
  • apps/web/public/locales/sk/app.json (1 hunks)
  • apps/web/public/locales/sv/app.json (1 hunks)
  • apps/web/public/locales/tr/app.json (1 hunks)
  • apps/web/public/locales/zh-Hant/app.json (1 hunks)
  • apps/web/public/locales/zh/app.json (1 hunks)
  • packages/emails/locales/da/emails.json (1 hunks)
  • packages/emails/locales/eu/emails.json (1 hunks)
  • packages/emails/locales/fi/emails.json (1 hunks)
  • packages/emails/locales/ja/emails.json (1 hunks)
  • packages/emails/locales/ko/emails.json (1 hunks)
  • packages/emails/locales/sv/emails.json (1 hunks)
💤 Files with no reviewable changes (13)
  • apps/landing/public/locales/da/home.json
  • apps/landing/public/locales/nl/home.json
  • apps/landing/public/locales/eu/home.json
  • apps/landing/public/locales/ru/home.json
  • apps/landing/public/locales/no/home.json
  • apps/landing/public/locales/fr/home.json
  • apps/landing/public/locales/pl/home.json
  • apps/landing/public/locales/zh/home.json
  • apps/landing/public/locales/pt-BR/home.json
  • apps/landing/public/locales/es/home.json
  • apps/landing/public/locales/de/home.json
  • apps/landing/public/locales/ko/home.json
  • apps/landing/public/locales/ja/home.json
✅ Files skipped from review due to trivial changes (3)
  • apps/landing/public/locales/sv/home.json
  • apps/landing/public/locales/it/home.json
  • apps/landing/public/locales/ca/home.json
🚧 Files skipped from review as they are similar to previous changes (18)
  • apps/web/public/locales/ja/app.json
  • apps/web/public/locales/ko/app.json
  • apps/web/public/locales/da/app.json
  • apps/web/public/locales/zh-Hant/app.json
  • apps/web/public/locales/cs/app.json
  • apps/web/public/locales/eu/app.json
  • apps/web/public/locales/es/app.json
  • apps/web/public/locales/ru/app.json
  • apps/web/public/locales/pt/app.json
  • apps/web/public/locales/fr/app.json
  • apps/web/public/locales/hr/app.json
  • apps/web/public/locales/pl/app.json
  • apps/web/public/locales/it/app.json
  • apps/web/public/locales/zh/app.json
  • apps/web/public/locales/tr/app.json
  • apps/web/public/locales/pt-BR/app.json
  • apps/web/public/locales/sk/app.json
  • apps/web/public/locales/no/app.json
🔇 Additional comments (27)
apps/landing/public/locales/cs/pricing.json (1)

31-32: LGTM! Translations are accurate and consistent.

The Czech translations maintain proper placeholder usage and consistent meaning with other language versions.

apps/landing/public/locales/hr/pricing.json (1)

31-32: LGTM! Translations are accurate and consistent.

The Croatian translations maintain proper placeholder usage and consistent meaning with other language versions.

apps/landing/public/locales/sk/pricing.json (1)

31-32: LGTM! Translations are accurate with natural language adaptation.

The Slovak translations maintain proper placeholder usage and consistent meaning, with "teraz" (now) added to make the pricing title more natural in Slovak.

apps/landing/public/locales/tr/pricing.json (1)

31-32: LGTM! Translations are accurate and consistent.

The Turkish translations maintain proper placeholder usage and consistent meaning with other language versions.

apps/landing/public/locales/ca/pricing.json (1)

31-32: LGTM! Translations are accurate and consistent.

The Catalan translations maintain proper placeholder usage and consistent meaning with other language versions.

apps/landing/public/locales/it/pricing.json (1)

31-32: LGTM! The localization changes look good.

The new pricing title is consistent with the existing Italian translations and aligns well with the corresponding translations in other language files. The formatting is correct and maintains the JSON structure.

packages/emails/locales/ko/emails.json (1)

16-16: LGTM! Korean translation for login heading.

The translation "로그인" is accurate and consistent with standard Korean UI terminology for "Login".

packages/emails/locales/ja/emails.json (1)

50-50: LGTM! Japanese translation for email verification preview.

The translation "メールアドレスを認証してください" (Please verify your email address) is accurate and maintains appropriate formality.

apps/landing/public/locales/zh-Hant/home.json (1)

30-30: Verify the intentional removal of self-hosting references.

The removal of the "selfHostingBlog" key appears to be part of a broader change across all language files. Let's verify this is intentional.

✅ Verification successful

Self-hosting references have been consistently removed

The removal of "selfHostingBlog" key is verified to be an intentional change, as it has been systematically removed across all language files in the localization system.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if any language files still contain selfHostingBlog references
echo "Checking for remaining selfHostingBlog references..."
rg -l "selfHostingBlog" "apps/landing/public/locales/"

Length of output: 167


Script:

#!/bin/bash
# List all locale files and their content
echo "Listing all locale files..."
fd . "apps/landing/public/locales" -e json -x echo "=== {} ===" \; cat "{}"

echo -e "\nSearching with case-insensitive pattern..."
rg -i "selfhosting|self.?hosting" "apps/landing/public/locales/"

Length of output: 6468

apps/landing/public/locales/cs/home.json (1)

30-30: LGTM! Czech meta description retained correctly.

The meta description "Vytvořte hlasování a najděte společně nejlepší den nebo čas. Bezplatná alternativa k Doodle." is well-maintained and accurately conveys the product's value proposition.

apps/landing/public/locales/sk/home.json (1)

30-30: LGTM! Slovak meta description retained correctly.

The meta description "Naplánujte si skupinové stretnutia v ten najvhodnejší čas. Bezplatná alternatíva k službe Doodle." is well-maintained and accurately conveys the product's value proposition.

apps/landing/public/locales/hr/home.json (1)

30-30: LGTM! Clean up of trailing space.

The changes maintain consistency with other language files while improving code quality.

apps/landing/public/locales/pt/home.json (1)

30-30: LGTM! Consistent with other language files.

The changes align with the cleanup performed across all localization files.

apps/landing/public/locales/tr/home.json (1)

35-36: Verify translation consistency across languages.

The new key "meetingPollMetaTitle" appears to be added only in Turkish. Please ensure this translation is added to all other language files for consistency.

✅ Verification successful

Translation consistency verified

The key "meetingPollMetaTitle" is present in all language files (16 locales) under apps/landing/public/locales/*/home.json. No inconsistency found.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if meetingPollMetaTitle exists in all language files
# Expected: The key should exist in all language files or none

echo "Checking for meetingPollMetaTitle across all language files:"
fd . "apps/landing/public/locales" -e json -x grep -l "meetingPollMetaTitle" {} \;

Length of output: 873

packages/emails/locales/sv/emails.json (1)

49-50: LGTM! Email verification string added consistently.

The addition of "changeEmailRequest_preview" maintains consistency with other language files while providing proper Swedish localization.

packages/emails/locales/da/emails.json (1)

49-50: LGTM! Email verification string added consistently.

The addition of "changeEmailRequest_preview" maintains consistency with other language files while providing proper Danish localization.

packages/emails/locales/eu/emails.json (1)

49-50: LGTM!

The changes improve the clarity of the poll sharing instructions and add support for email verification functionality.

apps/landing/public/locales/fi/home.json (1)

42-43: LGTM!

The changes enhance the meeting poll description and add support for the new quick creation feature.

packages/emails/locales/fi/emails.json (1)

49-56: LGTM!

The changes add comprehensive support for email change request functionality with clear and consistent messaging.

apps/landing/public/locales/hu/home.json (1)

42-43: LGTM!

The changes enhance the meeting poll description and add support for the new quick creation feature.

apps/web/public/locales/ca/app.json (1)

254-259: LGTM!

The changes add well-formatted strings to support various features including annual benefits, percentage savings, navigation, email verification, user feedback, and registration description.

apps/web/public/locales/nl/app.json (1)

284-288: LGTM! Dutch translations are accurate and consistent.

The new translations for email verification and registration flow are grammatically correct and maintain consistency with the existing translations.

apps/web/public/locales/de/app.json (1)

284-290: LGTM! German translations are accurate and consistent.

The new translations for email verification, registration flow, and login messages are grammatically correct and maintain consistency with the existing translations.

apps/web/public/locales/fi/app.json (1)

272-308: LGTM! Finnish translations are accurate and comprehensive.

The new translations for email verification, registration flow, and quick actions are grammatically correct and maintain consistency with the existing translations. The quick actions section is particularly well translated, maintaining the friendly tone of the original text.

apps/web/public/locales/hu/app.json (1)

285-308: LGTM! Hungarian translations are accurate and comprehensive.

The new translations for registration flow and quick actions are grammatically correct and maintain consistency with the existing translations.

apps/web/public/locales/sv/app.json (2)

268-272: LGTM! The new translations look good.

The added translations are consistent with authentication flow changes and provide clear Swedish translations for:

  • "subscribe" → "Prenumerera"
  • "back" → "Tillbaka"
  • "verifyEmail" → "Verifiera din e-postadress"
  • "userNotFound" → "En användare med den e-postadressen existerar inte"
  • "registerDescription" → "Effektivisera din schemaläggning och spara tid"

Let's verify the consistency of these translations across other language files:

✅ Verification successful

Swedish translations are accurate and complete

The Swedish translations are semantically correct and maintain consistency with the English source text while using natural Swedish language constructs. While some other language files are missing translations, this is outside the scope of the current review of Swedish translations.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if these new keys exist in other language files
# and compare their translations for consistency

# Find all app.json files in the locales directory
fd -e json -p 'locales/.*/app.json' | while read -r file; do
  echo "=== Checking $file ==="
  # Extract and display the values for the new keys
  jq -r '.subscribe // empty, .back // empty, .verifyEmail // empty, .userNotFound // empty, .registerDescription // empty' "$file"
done

Length of output: 11814


Line range hint 1-272: Verify the impact of removed translations.

The following translations were removed as mentioned in the AI summary:

  • "alreadyRegistered"
  • "loginWith"
  • "continueAsGuest"

Let's verify that these removals don't create gaps in the authentication flow:

✅ Verification successful

Removed translations verified as safe to remove

The translations "alreadyRegistered", "loginWith", and "continueAsGuest" are not referenced anywhere in the codebase and have been consistently removed from all locale files. The changes are safe.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if the removed keys are still referenced in the codebase

# Search for references to the removed translation keys
echo "=== Checking for references to removed translations ==="
rg -l "alreadyRegistered|loginWith|continueAsGuest" --type ts --type tsx

# Search for any remaining occurrences of these keys in other language files
echo "=== Checking for keys in other language files ==="
fd -e json -p 'locales/.*/app.json' | while read -r file; do
  jq -r 'select(.alreadyRegistered != null or .loginWith != null or .continueAsGuest != null) | keys[]' "$file"
done

Length of output: 6587


Script:

#!/bin/bash
# Search for references to the removed translation keys in TypeScript files
echo "=== Checking for references to removed translations ==="
rg -t typescript -t typescriptreact 'alreadyRegistered|loginWith|continueAsGuest' -C 2

# Check authentication-related files specifically
echo "=== Checking auth-related files ==="
fd -e ts -e tsx | grep -i "auth\|login\|register" | xargs rg 'alreadyRegistered|loginWith|continueAsGuest' -C 2

# List all translation files that still contain these keys
echo "=== Checking all locale files for inconsistencies ==="
fd -e json -p 'locales/.*/app.json' -x jq -r 'select(.alreadyRegistered != null or .loginWith != null or .continueAsGuest != null) | path(.)'

Length of output: 1760

@@ -289,5 +281,29 @@
"emailChangeRequestSentDescription": "Hogy véglegesítsd a változást, ellenőrizd az email fiókod a hitelesítő linkért.",
"profileEmailAddress": "Email cím",
"profileEmailAddressDescription": "Az email címed használhatod a belépéshez",
"emailAlreadyInUse": "Ez az eamil cím már társítva van egy másik felhasználóhoz. Kérjük használj másik felhasználot!"
"emailAlreadyInUse": "Ez az email cím már társítva van egy másik felhasználóhoz. Kérjük használj másik felhasználot.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix grammatical error in Hungarian translation.

The translation has a grammatical error in the word "felhasználot" (should be "felhasználót").

Apply this diff to fix the error:

-  "emailAlreadyInUse": "Ez az email cím már társítva van egy másik felhasználóhoz. Kérjük használj másik felhasználot.",
+  "emailAlreadyInUse": "Ez az email cím már társítva van egy másik felhasználóhoz. Kérjük használj másik felhasználót.",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"emailAlreadyInUse": "Ez az email cím már társítva van egy másik felhasználóhoz. Kérjük használj másik felhasználot.",
"emailAlreadyInUse": "Ez az email cím már társítva van egy másik felhasználóhoz. Kérjük használj másik felhasználót.",

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
packages/emails/locales/pt/emails.json (1)

50-56: Consider reordering the email verification entries for better maintainability.

The email change verification entries would be more maintainable if ordered logically to match the email flow:

  1. Preview & subject
  2. Heading
  3. Text1 (main message)
  4. Text2 (action instruction)
  5. Button
  6. Text3 (expiration warning)
  "changeEmailRequest_preview": "Por favor, confirme o seu endereço de e-mail",
  "changeEmailRequest_subject": "Verifique o seu novo endereço de e-mail",
  "changeEmailRequest_heading": "Verifique o seu novo endereço de e-mail",
+ "changeEmailRequest_text1": "Recebemos um pedido para alterar o e-mail da sua conta de <b>{{fromEmail}}</b> para <b>{{toEmail}}</b>.",
  "changeEmailRequest_text2": "Para efetuar esta alteração, clique no botão abaixo:",
  "changeEmailRequest_button": "Verifique endereço de e-mail",
- "changeEmailRequest_subject": "Verifique o seu novo endereço de e-mail",
  "changeEmailRequest_text3": "Este link expira dentro de 10 minutos. Se não solicitou esta alteração, ignore este e-mail.",
- "changeEmailRequest_text1": "Recebemos um pedido para alterar o e-mail da sua conta de <b>{{fromEmail}}</b> para <b>{{toEmail}}</b>."
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7fe23af and 8533f7e.

📒 Files selected for processing (5)
  • apps/landing/public/locales/pt/common.json (1 hunks)
  • apps/landing/public/locales/pt/home.json (2 hunks)
  • apps/landing/public/locales/pt/pricing.json (2 hunks)
  • apps/web/public/locales/pt/app.json (6 hunks)
  • packages/emails/locales/pt/emails.json (1 hunks)
🔇 Additional comments (10)
apps/landing/public/locales/pt/common.json (1)

26-28: LGTM! Translations are accurate and consistent.

The Portuguese translations maintain proper grammar and effectively convey the intended meaning.

apps/landing/public/locales/pt/pricing.json (2)

11-11: LGTM! Improved terminology consistency.

The change from "configurações" to "definições" and the addition of "a sua" improves language consistency and grammar.

Also applies to: 13-13


31-33: LGTM! Clear and well-structured pricing information.

The new pricing-related translations are clear, concise, and maintain consistent formatting.

apps/landing/public/locales/pt/home.json (2)

13-14: LGTM! Proper implementation of number formatting.

The translations correctly use ICU MessageFormat for number formatting, ensuring proper localization of statistics.


28-42: LGTM! Well-structured SEO and marketing content.

The translations maintain consistent marketing terminology and provide clear, localized meta descriptions for SEO purposes.

apps/web/public/locales/pt/app.json (3)

101-101: LGTM! Consistent terminology updates.

The change from "configurações" to "definições" maintains consistency across the application.

Also applies to: 127-127


255-263: LGTM! Clear error handling messages.

The profile picture upload error messages are clear, informative, and maintain proper Portuguese grammar.


273-284: LGTM! Well-structured authentication flow.

The authentication-related translations provide clear user guidance and maintain consistent terminology.

packages/emails/locales/pt/emails.json (2)

48-48: LGTM!

The formatting change maintains consistency with other entries while preserving the same content.


49-49: LGTM!

The new poll preview message is clear, actionable, and grammatically correct in Portuguese.

packages/emails/locales/pt/emails.json Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – landing January 22, 2025 04:03 Inactive
@vercel vercel bot temporarily deployed to Preview – landing January 22, 2025 12:59 Inactive
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apps/web/public/locales/nl/app.json (1)

285-286: Consider consolidating similar translation strings.

The strings "continueWith" and "continueWithProvider" have slightly different translations but serve the same purpose:

"continueWith": "Inloggen met {provider}",
"continueWithProvider": "Inloggen met {{provider}}"

Consider using the same format for both to maintain consistency. The first format with single curly braces is preferred as it follows the standard interpolation pattern used throughout the file.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8a2e673 and f4934e2.

📒 Files selected for processing (2)
  • apps/landing/public/locales/nl/home.json (1 hunks)
  • apps/web/public/locales/nl/app.json (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/landing/public/locales/nl/home.json
🔇 Additional comments (3)
apps/web/public/locales/nl/app.json (3)

231-231: LGTM! Clear and natural translations for group poll functionality.

The Dutch translations for "Groepspoll" and its description are accurate and maintain consistency with the rest of the UI.

Also applies to: 232-232


281-283: LGTM! Well-structured email change workflow messages.

The Dutch translations for email change workflow are clear, professional, and provide appropriate guidance to users in each state.


284-308: LGTM! Comprehensive and well-structured authentication flow translations.

The Dutch translations for the authentication flow are clear, maintain a consistent tone, and provide good user guidance throughout the process.

@lukevella lukevella merged commit 001e17b into main Jan 22, 2025
5 checks passed
@lukevella lukevella deleted the l10n_main branch January 22, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant