Add ErrorCode enum to LinearStage #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvreeven
approved these changes
Jul 10, 2024
| @@ -2,6 +2,17 @@ | |||
| <?xml-stylesheet type="text/xsl" href="http://lsst-sal.tuc.noao.edu/schema/SALEventSet.xsl"?> | |||
| <SALEventSet xmlns:xsi="http://lsst-sal.tuc.noao.edu/schema/SALEventSet.xsd"> | |||
| <Enumeration>DetailedState_NotMovingState, DetailedState_MovingState</Enumeration> | |||
| <Enumeration> | |||
| ErrorCode_ConnectionFailed, | |||
There was a problem hiding this comment.
I see that the python enum explicitly defines the values of the enum. Please do that here as well like so:
ErrorCode_ConnectionFailed=1,
and also for the rest of the values of this enum.
couger01
force-pushed
the
tickets/DM-45062
branch
from
a370dbd to
6ea6025
Compare
couger01
force-pushed
the
tickets/DM-45062
branch
from
6ea6025 to
25a02fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.