Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/provisioning rollup #168

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

F/provisioning rollup #168

wants to merge 15 commits into from

Conversation

@justinyost
Copy link
Contributor

LGTM 👍 Thanks.

@beporter
Copy link
Contributor Author

Okay, should be ready, but depends on loadsys/CakePHP-LoadsysTheme#25 being merged and tagged first.

@beporter beporter added review and removed wip labels Jun 15, 2016
@beporter beporter assigned justinyost and unassigned beporter Jun 15, 2016
@beporter
Copy link
Contributor Author

beporter commented Jun 15, 2016

LogTraitTest is currently using app.users fixture.

It probably doesn't HAVE to use any fixtures if the Table class being used were mocked instead of created through the TableRegistry.

Manifests in a freshly spawned app like this:

$ bin/phpunit 
Cleared cache: default
Cleared cache: _cake_core_
Cleared cache: _cake_model_
Skipped cache: sessions

PHPUnit 4.8.26 by Sebastian Bergmann and contributors.

.............I.............SSS.
Exception: Referenced fixture class "App\Test\Fixture\UsersFixture" not found. 
Fixture "app.users" was referenced in test case "App\Test\TestCase\Lib\Log\LogTraitTest". 
in [/var/www/vendor/cakephp/cakephp/src/TestSuite/Fixture/FixtureManager.php, line 214]

@beporter
Copy link
Contributor Author

Fixed.

@beporter
Copy link
Contributor Author

Code coverage for a freshly spawned project sits at about 93%. Not too shabby!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants