Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/sniff rollups #25

Merged
merged 8 commits into from
Jun 20, 2016
Merged

F/sniff rollups #25

merged 8 commits into from
Jun 20, 2016

Conversation

beporter
Copy link
Contributor

Integrates corrections for updated sniff rules. Specifically:

  • Multi-line arrays should now include a trailing comma by default.
  • File and class doc blocks are a bit more consistent (probably still needs work.)
  • Migration template files are included, so bin/cake bake migration --theme LoadsysTheme ... is now recommended. This will produce files that use tabs, have doc blocks and place open braces on the same line.

This work hasn't been tested yet. I need to coordinate with work in the skeleton to:

  1. Integrate this branch of the LoadsysTheme into the skeleton somehow.
  2. Bake a project from the skeleton "in-progress".
  3. Bake example migrations and code in the spawned project.
  4. Run the code-sniffer and unit tests on the resulting baked code.

Also, it would be cool if there was a way to make the default BakeShell someone "know" to use --theme LoadsysTheme "by default" without it having to be specified. Seems like this should be possible, but it requires investigation. I'd like to do this via an Event hook or Configure so it can be done (and customized) on a per-project basis, instead of depending on a wrapper bash script.

@beporter beporter self-assigned this Jun 14, 2016
@beporter beporter added review and removed wip labels Jun 15, 2016
@beporter beporter assigned justinyost and unassigned beporter Jun 15, 2016
@beporter
Copy link
Contributor Author

The commits are kind of messy, but the work is all here. This branch needs to be merged and a 1.1.0 versions tagged and released on Packagist before loadsys/CakePHP-Skeleton#168 can be merged and tagged safely.

@justinyost justinyost merged commit c3145ef into master Jun 20, 2016
@justinyost justinyost deleted the f/sniff-rollups branch June 20, 2016 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants