Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Power on with duration, power on if brightness > 0 #40

Closed
wants to merge 22 commits into from
Closed

Power on with duration, power on if brightness > 0 #40

Changes from 3 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
4a4bf48
Power on with duration, power on if brightness > 0
p1r473 Sep 19, 2021
b49e703
Update cli.py
p1r473 Sep 19, 2021
9dcfd04
Blacked
p1r473 Sep 19, 2021
e0e2ea3
Update cli.py
p1r473 Oct 25, 2021
0046692
Update cli.py
p1r473 Oct 25, 2021
d63e9db
Update cli.py
p1r473 Oct 25, 2021
e8b629e
Create cli.py
p1r473 Oct 25, 2021
9c99912
Update cli.py
p1r473 Oct 25, 2021
685cc2a
Blacked
p1r473 Oct 25, 2021
23d9ef6
Update cli.py
p1r473 Oct 26, 2021
a1ca511
Update cli.py
p1r473 Oct 26, 2021
21aa2c6
added support for Debian Bullseye
p1r473 Jul 27, 2022
ccaaf5c
add support for bullseye
p1r473 Jul 27, 2022
6e0b808
add support for bullseye
p1r473 Jul 27, 2022
98b92ce
clean up
p1r473 Jul 27, 2022
74630d3
clean up
p1r473 Jul 27, 2022
eea4743
blacked
p1r473 Jul 27, 2022
eb55422
blacked??
p1r473 Jul 27, 2022
27cacb3
Removed new path stuff
p1r473 Aug 1, 2022
797b159
Fix whitespace change
p1r473 Aug 1, 2022
bf2d2e9
Fix https://github.com/linusg/rpi-backlight/pull/40#discussion_r93430…
p1r473 Aug 1, 2022
cb15998
Fixed https://github.com/linusg/rpi-backlight/pull/40#discussion_r934…
p1r473 Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions rpi_backlight/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import time
from argparse import ArgumentParser

from . import Backlight, BoardType, __version__, utils
Expand Down Expand Up @@ -100,8 +101,13 @@ def main():
"-b/--set-brightness must be used without other options except for -d/--duration"
)
# backlight.fade context manager can be used always as args.fade defaults to zero
if (backlight.power == False) and (args.set_brightness > 0):
p1r473 marked this conversation as resolved.
Show resolved Hide resolved
backlight.power = True
with backlight.fade(duration=args.duration):
backlight.brightness = args.set_brightness
if (backlight.power == True) and (args.set_brightness == 0):
time.sleep(args.duration)
p1r473 marked this conversation as resolved.
Show resolved Hide resolved
backlight.power = False
return

if args.set_power:
Expand All @@ -120,6 +126,18 @@ def main():
backlight.power = True
with backlight.fade(duration=args.duration):
backlight.brightness = 100
elif args.set_power == "on":
if backlight.power:
return
p1r473 marked this conversation as resolved.
Show resolved Hide resolved
with backlight.fade(duration=args.duration):
backlight.brightness = 100
p1r473 marked this conversation as resolved.
Show resolved Hide resolved
time.sleep(args.duration)
p1r473 marked this conversation as resolved.
Show resolved Hide resolved
backlight.power = True if args.set_power == "on" else False
p1r473 marked this conversation as resolved.
Show resolved Hide resolved
elif args.set_power == "off":
with backlight.fade(duration=args.duration):
backlight.brightness = 0
time.sleep(args.duration)
backlight.power = False if args.set_power == "off" else True
else:
backlight.power = True if args.set_power == "on" else False
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch is now dead code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ive moved the new path stuff to
https://github.com/j-coopz/rpi-backlight
So this branch can still be about the previous issues

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea what that means, but please update if you want to get this PR merged

Copy link
Contributor Author

@p1r473 p1r473 Aug 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Linus, could you please elaborate what you want updated in this code?
This new code does the following:
-Power on/off is now supported with duration
-If setting brightness >0, turn the power on first. (This will better the user experience)
-If setting brightness to 0, turn the power off once brightness is 0. (Perhaps $ energy savings?)

return
Expand Down