Power on with duration, power on if brightness > 0 #40
Conversation
Power on with duration, power on if brightness > 0
|
Hi @p1r473 - sorry for ignoring your PR for so long! Totally missed this, only saw it when looking at the other issue earlier. |
|
Ping @linusg |
added support for Debian Bullseye
add support for bullseye
add support for bullseye
| if args.duration: | ||
| with backlight.fade(duration=args.duration): | ||
| backlight.brightness = 0 | ||
| backlight.power = False | ||
| else: | ||
| backlight.power = True if args.set_power == "on" else False |
There was a problem hiding this comment.
Ive moved the new path stuff to
https://github.com/j-coopz/rpi-backlight
So this branch can still be about the previous issues
There was a problem hiding this comment.
No idea what that means, but please update if you want to get this PR merged
There was a problem hiding this comment.
Hi Linus, could you please elaborate what you want updated in this code?
This new code does the following:
-Power on/off is now supported with duration
-If setting brightness >0, turn the power on first. (This will better the user experience)
-If setting brightness to 0, turn the power off once brightness is 0. (Perhaps $ energy savings?)
|
Ive moved the new path stuff into #50 |
Hi Linus,
On my Pi4, I am able to successfully fade with a duration with
rpi-backlight -b 0 -d 3. However, I cant power on/off with a durationrpi-backlight -p off -d 3. I can, however, toggle with a duration just finerpi-backlight -p toggle -d 3I believe we should be able to power on/off with a duration based on this line in the code, showing the intention that power setting may indeed be set with a duration.
parser.error("-p/--set-power may only be used with -d/--duration")After checking the code, I found that powering on/off with a duration wasn't actually implemented yet
So, I added it as a feature:
-Power on/off is now supported with duration
Additionally, I found that if you set the brightness to 100 while the power is off, nothing happens. So, I added an extra 2 features:
-If setting brightness >0, turn the power on first. (This will better the user experience)
-If setting brightness to 0, turn the power off once brightness is 0. (Perhaps $ energy savings?)
I also added a quick check to the code.
-Do not try to power on if already on (This will prevent the brightness from setting to 100 if brightness is already turned up (i.e. 40) and you try to power on)