Add transparency support to render_to_surface. #801
Conversation
| @@ -502,6 +502,7 @@ impl Renderer { | |||
| scene: &Scene, | |||
| surface: &SurfaceTexture, | |||
| params: &RenderParams, | |||
| clear: bool, | |||
There was a problem hiding this comment.
A bare boolean parameter is very rarely understandable. I think the best solution here would be to move clear into being a field of RendererOptions. (We'd need to also then make it a field of Renderer).
Clearly that's not ideal in all cases. I hope that we can remove render_to_surface entirely soon. But that's been planned for probably a year, so...
There was a problem hiding this comment.
I personally think that render_to_surface shouldn't be removed, mostly because it is a function that i depend a lot on to display to the screen directly, without having to set it up manually.
And moving the boolean to the Renderer kills a bit of flexibility, since by using this bool inside of the function, it allows you to split scenes in separate draw calls if you need to, and still being able to use the same renderer.
There was a problem hiding this comment.
Still, if you guys remove it at some point, it's totally fine! But, i think this function works pretty well, and this fix should allow the surface to have transparency for now c:
There was a problem hiding this comment.
render_to_surface is a really terrible API, for a number of reasons. It's definitely going.
With the new wgpu release, you will be able to use TextureBlitter, which will make render_to_surface almost trivial.
I don't know if we'll end up writing our own utility for it.
This tiny PR adds the feature suggested in #549.
It adds transparency support for
render_to_surface, with the addition of being able to render scenes on top of already rendered stuff with this function by giving you the option to choose if you want to clear the screen before drawing via an extra argument called "clear". If the check is true, it clears the screen before drawing the scene; if it is false, it doesn't.