Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web-sys pin comment. #447

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Update web-sys pin comment. #447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions examples/with_winit/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ android_logger = "0.13.0"
console_error_panic_hook = "0.1.7"
console_log = "1"
wasm-bindgen-futures = "0.4.33"
# Note: pinning the exact dep here because 0.3.65 broke semver. Update this
# when revving wgpu.
# Note: pin web-sys to 0.3.67 because wgpu 0.19 depends on that exact version.
# Update this when revving wgpu. Remove pin when wgpu no longer demands it.
Copy link
Member

@DJMcNab DJMcNab Feb 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that it will be trivial to work out when "no longer demands it" is true/correct. I don't have a better phrasing at the moment, though

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will definitely involve manual work. My goal was more so to point out that the issue isn't strictly from the web-sys crate but how wgpu uses it.

# See https://github.com/gfx-rs/wgpu/pull/5224 for more info.
web-sys = { version = "=0.3.67", features = [ "HtmlCollection", "Text" ] }
getrandom = { version = "0.2.10", features = ["js"] }