Update web-sys pin comment. #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waywardmonkeys
approved these changes
Feb 19, 2024
DJMcNab
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
For clarity, the reason gfx-rs/wgpu#5224 (comment) doesn't apply to us is because we do require webgpu, and don't work with WebGL - meaning that we do unconditionally use the unstable features
| # Note: pinning the exact dep here because 0.3.65 broke semver. Update this | ||
| # when revving wgpu. | ||
| # Note: pin web-sys to 0.3.67 because wgpu 0.19 depends on that exact version. | ||
| # Update this when revving wgpu. Remove pin when wgpu no longer demands it. |
There was a problem hiding this comment.
I'm not sure that it will be trivial to work out when "no longer demands it" is true/correct. I don't have a better phrasing at the moment, though
There was a problem hiding this comment.
It will definitely involve manual work. My goal was more so to point out that the issue isn't strictly from the web-sys crate but how wgpu uses it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we moved past
web-sys0.3.65 which the previous comment talked about I wondered if we can remove the pin. No we can't, becausewgpudepends on an unstable API ofweb-systhat gets changed in patch versions. So I updated our comment to be more current and added a link to a recent relevantwgpuissue.