Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Peniko to released version. #440

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

xorgy
Copy link
Member

@xorgy xorgy commented Feb 14, 2024

No description provided.

Cargo.toml Outdated Show resolved Hide resolved
@xorgy xorgy force-pushed the bump-peniko-kurbo branch from d8d9189 to 1483e36 Compare February 14, 2024 18:26
@xorgy xorgy changed the title Bump Peniko and Kurbo to released versions. Bump Peniko to released version. Feb 14, 2024
@xorgy xorgy changed the title Bump Peniko to released version. Bump Peniko to released version, and set MSRV. Feb 14, 2024
@xorgy xorgy requested review from dfrg, DJMcNab and ratmice February 14, 2024 19:26
Copy link
Contributor

@Philipp-M Philipp-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works for me, thanks.

@xorgy xorgy force-pushed the bump-peniko-kurbo branch from 9c0110a to 9d56d24 Compare February 14, 2024 19:39
@xorgy xorgy enabled auto-merge February 14, 2024 19:39
@xorgy xorgy added this pull request to the merge queue Feb 14, 2024
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@xorgy xorgy disabled auto-merge February 14, 2024 19:45
@xorgy xorgy removed this pull request from the merge queue due to a manual request Feb 14, 2024
@xorgy xorgy force-pushed the bump-peniko-kurbo branch from 9d56d24 to 9da8520 Compare February 14, 2024 19:49
@xorgy xorgy enabled auto-merge February 14, 2024 19:50
@xorgy xorgy force-pushed the bump-peniko-kurbo branch from 9da8520 to 84615ef Compare February 14, 2024 19:51
@xorgy xorgy changed the title Bump Peniko to released version, and set MSRV. Bump Peniko to released version. Feb 14, 2024
@xorgy xorgy disabled auto-merge February 14, 2024 19:51
@xorgy xorgy enabled auto-merge February 14, 2024 19:51
@DJMcNab
Copy link
Member

DJMcNab commented Feb 14, 2024

I'd be happy to set an MSRV - it's easy to do, and we can always increase it later

I'd treat it the same way as Peniko, where it's not a promise, it's just an observation based on what testing we do.

It's just that if we are doing it, we should do it properly and check it in CI

@xorgy xorgy added this pull request to the merge queue Feb 14, 2024
Merged via the queue into linebender:main with commit b1bd9e3 Feb 14, 2024
8 checks passed
simbleau pushed a commit that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants