Use initial_value() to test that we don't assume zeroed buffers.

libscran · Jan 9, 2025 · b85879c · b85879c
1 parent 867fc6b
commit b85879c
Show file tree

Hide file tree

Showing 7 changed files with 51 additions and 10 deletions.
diff --git a/include/scran_variances/choose_highly_variable_genes.hpp b/include/scran_variances/choose_highly_variable_genes.hpp
@@ -219,7 +219,11 @@ void choose_highly_variable_genes(size_t n, const Stat_* statistic, Bool_* outpu
  */
 template<typename Bool_ = uint8_t, typename Stat_>
 std::vector<Bool_> choose_highly_variable_genes(size_t n, const Stat_* statistic, const ChooseHighlyVariableGenesOptions& options) {
-    std::vector<Bool_> output(n);
+    std::vector<Bool_> output(n
+#ifdef SCRAN_VARIANCES_TEST_INIT
+        , SCRAN_VARIANCES_TEST_INIT
+#endif
+    );
     choose_highly_variable_genes(n, statistic, output.data(), options);
     return output;
 }

diff --git a/include/scran_variances/fit_variance_trend.hpp b/include/scran_variances/fit_variance_trend.hpp
@@ -206,7 +206,18 @@ struct FitVarianceTrendResults {
      */
     FitVarianceTrendResults() {}
 
-    FitVarianceTrendResults(size_t n) : fitted(n), residuals(n) {}
+    FitVarianceTrendResults(size_t n) :
+        fitted(n
+#ifdef SCRAN_VARIANCES_TEST_INIT
+            , SCRAN_VARIANCES_TEST_INIT
+#endif
+        ),
+        residuals(n
+#ifdef SCRAN_VARIANCES_TEST_INIT
+            , SCRAN_VARIANCES_TEST_INIT
+#endif
+        )
+    {}
     /**
      * @endcond
      */

diff --git a/include/scran_variances/model_gene_variances.hpp b/include/scran_variances/model_gene_variances.hpp
@@ -95,7 +95,28 @@ struct ModelGeneVariancesResults {
      */
     ModelGeneVariancesResults() = default;
 
-    ModelGeneVariancesResults(size_t ngenes) : means(ngenes), variances(ngenes), fitted(ngenes), residuals(ngenes) {}
+    ModelGeneVariancesResults(size_t ngenes) :
+        means(ngenes
+#ifdef SCRAN_VARIANCES_TEST_INIT
+            , SCRAN_VARIANCES_TEST_INIT
+#endif
+        ),
+        variances(ngenes
+#ifdef SCRAN_VARIANCES_TEST_INIT
+            , SCRAN_VARIANCES_TEST_INIT
+#endif
+        ),
+        fitted(ngenes
+#ifdef SCRAN_VARIANCES_TEST_INIT
+            , SCRAN_VARIANCES_TEST_INIT
+#endif
+        ),
+        residuals(ngenes
+#ifdef SCRAN_VARIANCES_TEST_INIT
+            , SCRAN_VARIANCES_TEST_INIT
+#endif
+        )
+    {}
     /**
      * @endcond
      */

diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
@@ -39,6 +39,15 @@ add_executable(
 )
 decorate_test(libtest)
 
+add_executable(
+    dirtytest 
+    src/fit_variance_trend.cpp
+    src/model_gene_variances.cpp
+    src/choose_highly_variable_genes.cpp
+)
+decorate_test(dirtytest)
+target_compile_definitions(dirtytest PRIVATE "SCRAN_VARIANCES_TEST_INIT=scran_tests::initial_value()")
+
 add_executable(
     cuspartest
     src/model_gene_variances.cpp

diff --git a/tests/src/choose_highly_variable_genes.cpp b/tests/src/choose_highly_variable_genes.cpp
@@ -1,7 +1,6 @@
-#include <gtest/gtest.h>
+#include "scran_tests/scran_tests.hpp"
 
 #include "scran_variances/choose_highly_variable_genes.hpp"
-#include "scran_tests/scran_tests.hpp"
 
 #include <unordered_set>
 

diff --git a/tests/src/fit_variance_trend.cpp b/tests/src/fit_variance_trend.cpp
@@ -1,8 +1,7 @@
-#include <gtest/gtest.h>
-#include <random>
-
 #include "scran_tests/scran_tests.hpp"
 
+#include <random>
+
 #include "scran_variances/fit_variance_trend.hpp"
 
 TEST(FitVarianceTrendTest, Basic) {

diff --git a/tests/src/model_gene_variances.cpp b/tests/src/model_gene_variances.cpp
@@ -1,5 +1,3 @@
-#include <gtest/gtest.h>
-
 #include "scran_tests/scran_tests.hpp"
 
 #include "tatami/tatami.hpp"