Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warnings for v1b2 #7454

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Add deprecation warnings for v1b2 #7454

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb6b64d
Change structure of crd versions for PingSource
matzew Nov 15, 2023
d81b3f0
:lipstick: Add deprecation warning to v1beta2 resource version
matzew Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions config/core/resources/pingsource.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ spec:
group: sources.knative.dev
versions:
- &version
name: v1beta2
name: v1
served: true
storage: false
storage: true
subresources:
status: {}
schema:
Expand Down Expand Up @@ -214,9 +214,14 @@ spec:
type: string
jsonPath: ".status.conditions[?(@.type=='Ready')].reason"
- <<: *version
name: v1
name: v1beta2
served: true
storage: true
storage: false
# This indicates the v1beta2 version of the custom resource is deprecated.
# API requests to this version receive a warning header in the server response.
deprecated: true
# This overrides the default warning returned to API clients making v1beta2 API requests.
deprecationWarning: "sources.knative.dev/v1beta2 PingSource is deprecated; see https://knative.dev/docs/eventing/sources/ping-source/ for instructions to migrate to sources.knative.dev/v1 PingSource"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an actual changes from v1b1 to v1? I wonder if we should just say "just change version and it will work"

# v1 schema is identical to the v1beta2 schema
names:
categories:
Expand Down