Add deprecation warnings for v1b2 #7454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Wessendorf <[email protected]>
knative-prow
bot
added
size/S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7454 +/- ##
=======================================
Coverage 76.74% 76.74%
=======================================
Files 253 253
Lines 13916 13916
=======================================
Hits 10680 10680
Misses 2702 2702
Partials 534 534 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Matthias Wessendorf <[email protected]>
matzew
force-pushed
the
change_crd_structure_pingsource
branch
from
ff77b0f to
d81b3f0
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pierDipi
reviewed
Nov 15, 2023
| # API requests to this version receive a warning header in the server response. | ||
| deprecated: true | ||
| # This overrides the default warning returned to API clients making v1beta2 API requests. | ||
| deprecationWarning: "sources.knative.dev/v1beta2 PingSource is deprecated; see https://knative.dev/docs/eventing/sources/ping-source/ for instructions to migrate to sources.knative.dev/v1 PingSource" |
There was a problem hiding this comment.
Is there an actual changes from v1b1 to v1? I wonder if we should just say "just change version and it will work"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
Pre-review Checklist
Release Note
Docs