Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1B3 bump of Event Type #7304

Merged
merged 4 commits into from
Dec 1, 2023
Merged

V1B3 bump of Event Type #7304

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a773dce
V1B3 bump of Event Type
matzew Sep 27, 2023
c6dc844
little update
matzew Nov 14, 2023
9343f8c
Fix outstanding old version strings
dsimansk Nov 30, 2023
3e7aa56
Update license headers
dsimansk Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/apis/eventing/v1beta3/eventtype_conversion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ import (

// ConvertTo implements apis.Convertible
func (source *EventType) ConvertTo(ctx context.Context, to apis.Convertible) error {
return fmt.Errorf("v1beta2 is the highest known version, got: %T", to)
return fmt.Errorf("v1beta3 is the highest known version, got: %T", to)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy pasta 🍝

thx!

}

// ConvertFrom implements apis.Convertible
func (sink *EventType) ConvertFrom(ctx context.Context, from apis.Convertible) error {
return fmt.Errorf("v1beta2 is the highest known version, got: %T", from)
return fmt.Errorf("v1beta3 is the highest known version, got: %T", from)
}
10 changes: 5 additions & 5 deletions pkg/apis/eventing/v1beta3/eventtype_validation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Check failure on line 8 in pkg/apis/eventing/v1beta3/eventtype_validation_test.go

View workflow job for this annotation

GitHub Actions / style / Golang / Boilerplate Check (go) 

[Go headers] reported by reviewdog 🐶
found mismatched boilerplate lines:

Raw Output:
pkg/apis/eventing/v1beta3/eventtype_validation_test.go:8: found mismatched boilerplate lines:
{[]string}[0]:
	-: "\thttp://www.apache.org/licenses/LICENSE-2.0"
	+: "    http://www.apache.org/licenses/LICENSE-2.0"

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
Expand Down Expand Up @@ -163,7 +163,7 @@
want: &apis.FieldError{
Message: "Immutable fields changed (-old +new)",
Paths: []string{"spec"},
Details: `{v1beta2.EventTypeSpec}.Reference.Name:
Details: `{v1beta3.EventTypeSpec}.Reference.Name:
-: "original-broker"
+: "test-broker"
`,
Expand Down Expand Up @@ -195,7 +195,7 @@
want: &apis.FieldError{
Message: "Immutable fields changed (-old +new)",
Paths: []string{"spec"},
Details: `{v1beta2.EventTypeSpec}.Type:
Details: `{v1beta3.EventTypeSpec}.Type:
-: "original-type"
+: "test-type"
`,
Expand Down Expand Up @@ -227,7 +227,7 @@
want: &apis.FieldError{
Message: "Immutable fields changed (-old +new)",
Paths: []string{"spec"},
Details: `{v1beta2.EventTypeSpec}.Source.Host:
Details: `{v1beta3.EventTypeSpec}.Source.Host:
-: "original-source"
+: "test-source"
`,
Expand Down Expand Up @@ -261,7 +261,7 @@
want: &apis.FieldError{
Message: "Immutable fields changed (-old +new)",
Paths: []string{"spec"},
Details: `{v1beta2.EventTypeSpec}.Schema.Host:
Details: `{v1beta3.EventTypeSpec}.Schema.Host:
-: "original-schema"
+: "test-schema"
`,
Expand Down Expand Up @@ -297,7 +297,7 @@
want: &apis.FieldError{
Message: "Immutable fields changed (-old +new)",
Paths: []string{"spec"},
Details: `{v1beta2.EventTypeSpec}.Description:
Details: `{v1beta3.EventTypeSpec}.Description:
-: "original-description"
+: "test-description"
`,
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/eventing/v1beta3/register.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (
)

// SchemeGroupVersion is group version used to register these objects
var SchemeGroupVersion = schema.GroupVersion{Group: eventing.GroupName, Version: "v1beta2"}
var SchemeGroupVersion = schema.GroupVersion{Group: eventing.GroupName, Version: "v1beta3"}

// Kind takes an unqualified kind and returns back a Group qualified GroupKind
func Kind(kind string) schema.GroupKind {
Expand Down
Loading