Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1B3 bump of Event Type #7304

Merged
merged 4 commits into from
Dec 1, 2023
Merged

V1B3 bump of Event Type #7304

merged 4 commits into from
Dec 1, 2023

Conversation

matzew
Copy link
Member

@matzew matzew commented Sep 27, 2023 •
edited by dsimansk
Loading

Fixes #

Proposed Changes

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Introduce EventTypes v1beta3 version

Docs

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/test-and-release Test infrastructure, tests or release size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 27, 2023
@knative-prow knative-prow bot requested review from aslom and mgencur September 27, 2023 08:30
@knative-prow
Copy link

knative-prow bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2023
Cali0707
Cali0707 reviewed Oct 19, 2023
View reviewed changes
pkg/apis/eventing/v1beta3/eventtype_types.go
Comment on lines +68 to +69
// +optional
Source *apis.URL `json:"source,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// +optional
Source *apis.URL `json:"source,omitempty"`
Source *apis.URL `json:"source"`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From #7314 we should mark this as non-optional

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will go away anyways in this version. the source will be required to be inside the map (see #7265)

@matzew matzew force-pushed the v1beta3_eventtypes branch from b5669d4 to 40a3066 Compare November 14, 2023 10:32
@matzew matzew mentioned this pull request Nov 16, 2023
Closed
5 tasks
matzew and others added 3 commits November 30, 2023 14:35
@dsimansk
Copy link
Contributor

dsimansk commented Nov 30, 2023 •
edited
Loading

@matzew FYI I've fixed a few nits that failed unit tests & rebased to current HEAD. 🤞

@codecov Codecov
Copy link

codecov bot commented Nov 30, 2023 •
edited
Loading

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (5ce62f4) 76.68% compared to head (3e7aa56) 76.70%.
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/apis/eventing/v1beta3/eventtype_validation.go 74.07% 5 Missing and 2 partials ⚠️
pkg/apis/eventing/v1beta3/eventtype_lifecycle.go 75.00% 4 Missing ⚠️
pkg/apis/eventing/v1beta3/eventtype_types.go 66.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7304      +/-   ##
==========================================
+ Coverage   76.68%   76.70%   +0.02%     
==========================================
  Files         253      259       +6     
  Lines       14182    14254      +72     
==========================================
+ Hits        10875    10934      +59     
- Misses       2754     2765      +11     
- Partials      553      555       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

matzew
matzew commented Nov 30, 2023
View reviewed changes
pkg/apis/eventing/v1beta3/eventtype_conversion.go
@@ -25,10 +25,10 @@ import (

// ConvertTo implements apis.Convertible
func (source *EventType) ConvertTo(ctx context.Context, to apis.Convertible) error {
return fmt.Errorf("v1beta2 is the highest known version, got: %T", to)
return fmt.Errorf("v1beta3 is the highest known version, got: %T", to)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy pasta 🍝

thx!

matzew
matzew commented Nov 30, 2023
View reviewed changes
pkg/apis/eventing/v1beta3/register_test.go
@@ -1,5 +1,5 @@
/*
Copyright 2021 The Knative Authors
Copyright 2023 The Knative Authors
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's fair 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a bad formatting in one of the files. So I rather updated all with proper year as well. :)

@matzew matzew changed the title WIP: V1B3 bump of Event Type V1B3 bump of Event Type Nov 30, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2023
@dsimansk
Copy link
Contributor

dsimansk commented Dec 1, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2023
@knative-prow knative-prow bot merged commit 3fcc78a into knative:main Dec 1, 2023
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Cali0707 left review comments

@dsimansk dsimansk dsimansk left review comments

@aslom aslom Awaiting requested review from aslom

@mgencur mgencur Awaiting requested review from mgencur

Assignees

@dsimansk dsimansk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matzew @dsimansk @Cali0707