Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blog post about TM committee dissolving #5852

Merged
merged 5 commits into from
Feb 14, 2024
Merged

Blog post about TM committee dissolving #5852

merged 5 commits into from
Feb 14, 2024

Conversation

aliok
Copy link
Member

@aliok aliok commented Feb 3, 2024

@netlify Netlify
Copy link

netlify bot commented Feb 3, 2024 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ac6407a
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/65cc7e41312139000838a948
😎 Deploy Preview https://deploy-preview-5852--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot requested review from nainaz and ReToCode February 3, 2024 20:53
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 3, 2024
@aliok aliok mentioned this pull request Feb 3, 2024
Merged
@aliok
Copy link
Member Author

aliok commented Feb 3, 2024

/hold
Depends on knative/community#1506

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2024
@aliok aliok mentioned this pull request Feb 3, 2024
Closed
@aliok
Copy link
Member Author

aliok commented Feb 3, 2024

/assign @knative/steering-committee @knative/technical-oversight-committee

@aliok
Copy link
Member Author

aliok commented Feb 3, 2024 •
edited
Loading

I don't get why I don't see the new post in the navigation in the preview 😕

@ReToCode
Copy link
Member

ReToCode commented Feb 5, 2024

I don't get why I don't see the new post in the navigation in the preview 😕

You need to link it here: https://github.com/knative/docs/blob/main/blog/config/nav.yml

@krsna-m
Copy link
Contributor

krsna-m commented Feb 5, 2024

thanks for the blog post

@aliok
Copy link
Member Author

aliok commented Feb 14, 2024

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2024
@ReToCode
Copy link
Member

The title looks a bit off to me: https://deploy-preview-5852--knative.netlify.app/blog/steering/2024-02-04-trademark-committee-dissolved/. Other than that, LGTM

@aliok aliok force-pushed the 2024-02-03-dissolve-tm-committee branch from e3fbb5c to ac6407a Compare February 14, 2024 08:47
@aliok
Copy link
Member Author

aliok commented Feb 14, 2024

The title looks a bit off to me: https://deploy-preview-5852--knative.netlify.app/blog/steering/2024-02-04-trademark-committee-dissolved/. Other than that, LGTM

Oh, right.

Thanks!

https://deploy-preview-5852--knative.netlify.app/blog/steering/2024-02-14-trademark-committee-dissolved/ --> should be good now.

@aliok
Copy link
Member Author

aliok commented Feb 14, 2024

The process change is complete, we should be fine to merge this without additional SC approval or something, if the content is right.

ReToCode
ReToCode approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 52992cb into knative:main Feb 14, 2024
19 checks passed
@aliok aliok deleted the 2024-02-03-dissolve-tm-committee branch February 14, 2024 08:55
prushh pushed a commit to prushh/docs that referenced this pull request Apr 30, 2024
@aliok @prushh
Blog post about TM committee dissolving (knative#5852)
0d80090 
* Blogpost about TM committee dissolving

* Fix the date :(

* Add nav entry

* Fix frontmatter

* Rename file

Signed-off-by: Ali Ok <[email protected]>

---------

Signed-off-by: Ali Ok <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode ReToCode approved these changes

@nainaz nainaz Awaiting requested review from nainaz

Assignees

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aliok @ReToCode @krsna-m