Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General cleanup and Objective-C modernization #211

Merged
merged 24 commits into from
May 11, 2017
Merged

General cleanup and Objective-C modernization #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
87a6f88
Don't allow the changing of KeenClient keys using sharedClientWithPro…
danieltiger May 8, 2017
b883644
Removed the misleading validateProjectID and validateKey. They were c…
danieltiger May 8, 2017
804e262
Reverse the initial check to collapse a large branch. Remove outdated…
danieltiger May 8, 2017
0b0559f
Cleaned up stray *. Removed strong from property declarations as it's…
danieltiger May 8, 2017
a94e354
Removed strong from property declaration because it's the default. Ad…
danieltiger May 8, 2017
53b32d7
General cleanup.
danieltiger May 8, 2017
eae40ce
Removed strong from property declarations as it's the default. Remove…
danieltiger May 8, 2017
057c93c
Use self = [super init]; in case someone subclasses someday.
danieltiger May 8, 2017
4036e42
General cleanup.
danieltiger May 8, 2017
fe27688
General cleanup.
danieltiger May 8, 2017
73a99ac
General cleanup.
danieltiger May 8, 2017
58a9a16
General cleanup.
danieltiger May 8, 2017
81d6f14
No need to check for nil, a message sent in Objective-C to a nil rece…
danieltiger May 8, 2017
c33de21
No need for @synthesize. It's automatic for @property.
danieltiger May 8, 2017
81973bc
No need for @synthesize. It will be provided automatically.
danieltiger May 8, 2017
92b8d40
General cleanup.
danieltiger May 8, 2017
47d6703
General cleanup.
danieltiger May 8, 2017
ad956dc
Using the NS_UNAVAILABLE anotation, so no one can call the init metho…
danieltiger May 10, 2017
5ac6b56
Using the NS_UNAVAILABLE anotation, so no one can call the init metho…
danieltiger May 10, 2017
ccf6c8c
General cleanup.
danieltiger May 10, 2017
62a5a30
Bring back iOS 8 checks for now.
danieltiger May 11, 2017
fb1cd2d
Bring back selector check for now.
danieltiger May 11, 2017
d2af4c3
Remove major revision code.
danieltiger May 11, 2017
3e9dd5a
Revert the test.
danieltiger May 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion KeenClient/HTTPCodes.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ @implementation HTTPCodes
#pragma mark Code descriptions

+ (NSString *)descriptionForCode:(HTTPCode)code {

NSString *description = [NSString stringWithFormat:@"Unknown status code: %lu", (unsigned long)code];

switch (code) {
Expand Down
6 changes: 3 additions & 3 deletions KeenClient/KIODBStore.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
/**
Singleton instance of this class.
*/
+ (KIODBStore*)sharedInstance;
+ (KIODBStore *)sharedInstance;

/**
Reset any pending events so they can be resent.
Expand Down Expand Up @@ -60,7 +60,7 @@

@param eventId The id of the event to delete.
*/
- (void)deleteEvent: (NSNumber *)eventId;
- (void)deleteEvent:(NSNumber *)eventId;

/**
Delete all events from the store
Expand Down Expand Up @@ -88,7 +88,7 @@
@param eventCollection Your event collection.
@param projectID Your project ID.
*/
- (BOOL)addQuery:(NSData *)queryData queryType:(NSString*)queryType collection:(NSString *)eventCollection projectID:(NSString *)projectID;
- (BOOL)addQuery:(NSData *)queryData queryType:(NSString *)queryType collection:(NSString *)eventCollection projectID:(NSString *)projectID;

/**
Get a dictionary of the found query parameters.
Expand Down
Loading