General cleanup and Objective-C modernization#211

Merged

baumatron merged 24 commits intokeenlabs:masterfrom danieltiger:assorted-improvements

May 11, 2017

+385-484

Commits on May 8, 2017

Don't allow the changing of KeenClient keys using sharedClientWithProjectID:andWriteKey:andReadKey:, after they have been initially set.
danieltiger
committed
Removed the misleading validateProjectID and validateKey. They were checking for nil and empty string, but were being used in a way that indicated that wasn't clear.
danieltiger
committed
Reverse the initial check to collapse a large branch. Remove outdated iOS 8 checking code.
danieltiger
committed
Cleaned up stray *. Removed strong from property declarations as it's the default. Use containsString and hasPrefix instead of range checking.
danieltiger
committed
Removed strong from property declaration because it's the default. Added check for self in init.
danieltiger
committed
General cleanup.
danieltiger
committed
Removed strong from property declarations as it's the default. Removed confusing validate method and just check for nil/empty. No need to init to nil in Objective-C for objects.
danieltiger
committed
Use self = [super init]; in case someone subclasses someday.
danieltiger
committed
General cleanup.
danieltiger
committed
General cleanup.
danieltiger
committed
General cleanup.
danieltiger
committed
General cleanup.
danieltiger
committed
No need to check for nil, a message sent in Objective-C to a nil receiver is a no-op.
danieltiger
committed
No need for @synthesize . It's automatic for @Property .
danieltiger
committed
No need for @synthesize . It will be provided automatically.
danieltiger
committed
General cleanup.
danieltiger
committed
General cleanup.
danieltiger
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

General cleanup and Objective-C modernization#211

Commits on May 8, 2017

Don't allow the changing of KeenClient keys using sharedClientWithProjectID:andWriteKey:andReadKey:, after they have been initially set.

Removed the misleading validateProjectID and validateKey. They were checking for nil and empty string, but were being used in a way that indicated that wasn't clear.

Reverse the initial check to collapse a large branch. Remove outdated iOS 8 checking code.

Cleaned up stray *. Removed strong from property declarations as it's the default. Use containsString and hasPrefix instead of range checking.

Removed strong from property declaration because it's the default. Added check for self in init.

General cleanup.

Removed strong from property declarations as it's the default. Removed confusing validate method and just check for nil/empty. No need to init to nil in Objective-C for objects.

Use self = [super init]; in case someone subclasses someday.

General cleanup.

General cleanup.

General cleanup.

General cleanup.

No need to check for nil, a message sent in Objective-C to a nil receiver is a no-op.

No need for @synthesize . It's automatic for @Property .

No need for @synthesize . It will be provided automatically.

General cleanup.

General cleanup.

Commits on May 10, 2017

Using the NS_UNAVAILABLE anotation, so no one can call the init method. Other assorted minor cleanup.

Using the NS_UNAVAILABLE anotation, so no one can call the init method. Other assorted minor cleanup.

General cleanup.

Commits on May 11, 2017

Bring back iOS 8 checks for now.

Bring back selector check for now.

Remove major revision code.

Revert the test.