-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsk_robot_startup/smach_to_mail] Set sender address and receiver address from rosparam #71
Conversation
…ress from rosparam
@@ -29,8 +29,8 @@ def __init__(self): | |||
self.bridge = CvBridge() | |||
self.smach_state_list = {} # for status list | |||
self.smach_state_subject = {} # for status subject | |||
self.sender_address = "[email protected]" | |||
self.receiver_address = "[email protected]" | |||
self.sender_address = rospy.get_param("~sender_address") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tkmtnt7000 thank you, please add error checking code, when no param is set, use default value or raise errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for late.
I add error checking code(354bd5a)
I think there might be some demand that we don't want to write their email address (robot or personal one) on github, so I make it possible to set the email address from the yaml file as well. The implementation is based on email_topic.py. |
@tkmtnt7000 pleaes update documents,
In my opinion, we need to be very careful on using
--> Please discuss with @708yamaguchi and others, if we can remove |
OK. I'll write document about smach_to_mail.py overview first.
I understand. I will discuss with @708yamaguchi and other members whether to use |
This PR enables to set mail address from rosparam.
Related to jsk-ros-pkg#1558