-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dual_panda2 #1544
Add dual_panda2 #1544
Conversation
Either way is OK:
|
bcf47c1
to
bea7e50
Compare
@k-okada |
jsk_panda_robot/jsk_panda_startup/env-hooks/99.jsk_panda_startup.sh
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,285 @@ | |||
<?xml version="1.0"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
humm, is dual_panda and dual_panda2 different? do they have different gripper?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They have different sensors.
dual_panda1: xtion camera on head, web cameras on both hands, microphone on right hand
dual_panda2: realsense d435 on both hands
80b7298
to
3e3d06e
Compare
a9e704c
to
9d2d4fa
Compare
…rasp to change each parameter. Besides, changed default value of inner from 0.06 to 0.07
2baed24
to
648655d
Compare
They were copied from https://github.com/YoheiKakiuchi/franka_ros/tree/add_dual_arm, which does not match recent panda's gazebo. And we have no immediate plans to use gazebo. If you want to implement gazebo afresh, check https://github.com/frankaemika/franka_ros/tree/develop/franka_gazebo and https://github.com/k-okada/jsk_demos/tree/science_animal/science_animal
2de453b
to
633108d
Compare
…to default value change
11becfc
to
a8dcaf6
Compare
…amera -> /*arm_camera) & enable to specify resolution correctly Previously, specifying resolution failed because fps was not specified
…necessary info, ...
a8dcaf6
to
560b823
Compare
@k-okada |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly good. please check my comment
## Install ## | ||
############# | ||
|
||
install(DIRECTORY launch config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forget rviz directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rviz directory is inside config directory, so I think it is installed by current CMakeLists.txt:
leus@dual-panda1:~/test_ws/install/share/jsk_panda_startup/config/rviz$ ls
dual_panda1_play.rviz dual_panda2_play.rviz
|
||
catkin_package() | ||
|
||
install(DIRECTORY config launch python script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use catkin_install_python
jsk-ros-pkg/jsk_recognition#2743 ? (you do not have to check on 20.04.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe fixed
jsk_panda_robot/jsk_panda_teleop/python/end_effector_frames_publisher.py
Outdated
Show resolved
Hide resolved
jsk_panda_robot/jsk_panda_teleop/python/record_topic_synchronizer.py
Outdated
Show resolved
Hide resolved
a76cac8
to
44f917d
Compare
@k-okada |
@k-okada Kindly ping. |
Includes #1543
This PR adds
dual_panda2
robot, which is used in jsk-ros-pkg/jsk_demos#1363.cc @haraduka