Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with newer versions of editorconfig #140

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Conversation

jscheid
Copy link
Owner

@jscheid jscheid commented Aug 31, 2024

Emacs 30 ships with a new version of the editorconfig package, ensure we're compatible with it.

@jscheid jscheid changed the title Compatibility with Emacs 30 Compatibility with newer versions of editorconfig Aug 31, 2024
@jscheid jscheid marked this pull request as ready for review August 31, 2024 19:20
@jscheid jscheid requested a review from asbish August 31, 2024 19:20
Copy link
Collaborator

@asbish asbish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I've checked that editorconfig v0.11.0 is built-in in Emacs 30 and the editorconfig-set-local-variables was introduced in editorconfig-emacs v0.9.

@jscheid
Copy link
Owner Author

jscheid commented Sep 2, 2024

Thanks for checking it all @asbish, much appreciated. I've also used it all day today and no issues. Merging.

@jscheid jscheid merged commit dd7645a into master Sep 2, 2024
5 checks passed
@jscheid jscheid deleted the emacs-30-compat branch September 2, 2024 15:10
github-actions bot pushed a commit that referenced this pull request Sep 2, 2024
Compatibility with newer versions of editorconfig dd7645a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants