Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node-zopfli and build locally instructions #138

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

arichiardi
Copy link
Contributor

Two self-explanatory commits:

  • Add requirements for building locally to HACKING.m

  • Replace the deprecated node-zopfli-es with node-zopfli

    The former does not build with newer node/npm and the latter is
    recommended as replacement.

@arichiardi arichiardi force-pushed the build-from-source branch 2 times, most recently from 8d73393 to a05de9e Compare August 28, 2024 17:50
@arichiardi arichiardi marked this pull request as ready for review August 28, 2024 17:51
@jscheid
Copy link
Owner

jscheid commented Aug 28, 2024

Hey, thank you, I'll take a look at this soon.

I assume you're trying to build locally because you want to hack on it? That's cool and appreciated, but do note that I'm planning to put this project into maintenance mode soon - or maybe in a way it already is, in my mind. I'm working on a successor that I can reveal more about shortly, probably in a month's time or so.

PS: that new project will have a much less convoluted build 🙂

@arichiardi
Copy link
Contributor Author

@jscheid no problem, can't wait for the new one to happen 😄

I am building locally because my emacs setup is using borg, which is basically cloning the repo locally.

@jscheid
Copy link
Owner

jscheid commented Aug 29, 2024

Oh. Have you considered to point it at our release branch? This is where MELPA picks up from.
https://github.com/jscheid/prettier.el/tree/release

@arichiardi
Copy link
Contributor Author

Well I don't have much control on what branch I target - borg is doing it for me based on the registered one in Emacsmirror - I like this setup as it was very easy to hack on the project and provide this PR. This is indeed the very reason why I chose borg for package management 😄

@jscheid
Copy link
Owner

jscheid commented Aug 31, 2024

I'm going to dogfood #140 for a day or so before merging it, then I'll ask you to rebase your PR so that we can get clean CI build for it.

@jscheid
Copy link
Owner

jscheid commented Sep 2, 2024

@arichiardi done, would you mind rebasing?

@arichiardi
Copy link
Contributor Author

arichiardi commented Sep 13, 2024

@jscheid yep I can do that - done

The former does not build with newer node/npm and the latter is
recommended as replacement.
Small addition to our instructions, with plenty of disclaimers.
@arichiardi
Copy link
Contributor Author

@jscheid anything else I need for this one? I can maintain the branch going but it would be better to merge it in ;)

@jscheid jscheid merged commit 6892098 into jscheid:master Sep 24, 2024
5 checks passed
@jscheid
Copy link
Owner

jscheid commented Sep 24, 2024

@arichiardi all done now, thanks for your contribution!

@arichiardi arichiardi deleted the build-from-source branch September 27, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants