-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use node-zopfli and build locally instructions #138
Conversation
8d73393
to
a05de9e
Compare
Hey, thank you, I'll take a look at this soon. I assume you're trying to build locally because you want to hack on it? That's cool and appreciated, but do note that I'm planning to put this project into maintenance mode soon - or maybe in a way it already is, in my mind. I'm working on a successor that I can reveal more about shortly, probably in a month's time or so. PS: that new project will have a much less convoluted build 🙂 |
@jscheid no problem, can't wait for the new one to happen 😄 I am building locally because my emacs setup is using borg, which is basically cloning the repo locally. |
Oh. Have you considered to point it at our release branch? This is where MELPA picks up from. |
Well I don't have much control on what branch I target - |
I'm going to dogfood #140 for a day or so before merging it, then I'll ask you to rebase your PR so that we can get clean CI build for it. |
@arichiardi done, would you mind rebasing? |
@jscheid yep I can do that - done |
a05de9e
to
982dd9a
Compare
The former does not build with newer node/npm and the latter is recommended as replacement.
Small addition to our instructions, with plenty of disclaimers.
@jscheid anything else I need for this one? I can maintain the branch going but it would be better to merge it in ;) |
@arichiardi all done now, thanks for your contribution! |
Two self-explanatory commits:
Add requirements for building locally to HACKING.m
Replace the deprecated node-zopfli-es with node-zopfli
The former does not build with newer node/npm and the latter is
recommended as replacement.