Use =delete for private unimplemented constructor

jackburton79 · Oct 5, 2024 · ad87fc1 · ad87fc1
1 parent 7a89fc5
commit ad87fc1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 19 deletions.
diff --git a/ImageFilter.cpp b/ImageFilter.cpp
@@ -23,23 +23,6 @@ ImageFilter::ImageFilter(BRect frame, color_space colorSpace)
 }
 
 
-// private non-working
-ImageFilter::ImageFilter(const ImageFilter& other)
-	:
-	fBitmap(NULL),
-	fView(NULL)
-{
-}
-
-
-// private non-working
-ImageFilter&
-ImageFilter::operator=(const ImageFilter& other)
-{
-	return *this;
-}
-
-
 ImageFilter::~ImageFilter()
 {
 	delete fBitmap;

diff --git a/ImageFilter.h b/ImageFilter.h
@@ -26,8 +26,8 @@ class ImageFilter {
 	BBitmap* fBitmap;
 	BView* fView;
 
-	ImageFilter& operator=(const ImageFilter& other);
-	ImageFilter(const ImageFilter& other);
+	ImageFilter& operator=(const ImageFilter& other) = delete ;
+	ImageFilter(const ImageFilter& other) = delete ;
 };