Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular backend - T2I Adapter #6662

Merged
merged 3 commits into from
Jul 28, 2024

Conversation

StAlKeR7779
Copy link
Contributor

Summary

T2I Adapter code from #6577.

Related Issues / Discussions

#6606
https://invokeai.notion.site/Modular-Stable-Diffusion-Backend-Design-Document-e8952daab5d5472faecdc4a72d377b0d

QA Instructions

Run with and without set USE_MODULAR_DENOISE environment.

Merge Plan

Nope.
If you think that there should be some kind of tests - feel free to add.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added python PRs that change python files invocations PRs that change invocations backend PRs that change backend files labels Jul 23, 2024
Copy link
Collaborator

@RyanJDick RyanJDick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments.

Manual tests to be completed before merging (I've completed a few already.):

  • SDXL, Standard guidance, single T2I-Adapter
  • SDXL, Standard guidance, multiple T2I-Adapters
  • SDXL, Sequential guidance, single T2I-Adapter
  • SDXL, Sequential guidance, multiple T2I-Adapters
    At leat one test with SD1 to make sure that both SDXL and SD1 are working:
  • SD1, Standard guidance, single T2I-Adapter

@StAlKeR7779
Copy link
Contributor Author

StAlKeR7779 commented Jul 26, 2024

Just a few minor comments.

Manual tests to be completed before merging (I've completed a few already.):

  • SDXL, Standard guidance, single T2I-Adapter
  • SDXL, Standard guidance, multiple T2I-Adapters
  • SDXL, Sequential guidance, single T2I-Adapter
  • SDXL, Sequential guidance, multiple T2I-Adapters
    At leat one test with SD1 to make sure that both SDXL and SD1 are working:
  • SD1, Standard guidance, single T2I-Adapter

Tried:

  • SD1, Standard guidance, single T2I-Adapter
  • SD1, Standard guidance, multiple T2I-Adapters
  • SD1, Sequential guidance, single T2I-Adapter
  • SD1, Sequential guidance, multiple T2I-Adapters
  • SDXL, Standard guidance, single T2I-Adapter
  • SDXL, Standard guidance, multiple T2I-Adapters
  • SDXL, Sequential guidance, single T2I-Adapter
  • SDXL, Sequential guidance, multiple T2I-Adapters

Co-Authored-By: Ryan Dick <[email protected]>
@RyanJDick RyanJDick enabled auto-merge July 28, 2024 19:45
@RyanJDick RyanJDick merged commit ee7503c into invoke-ai:main Jul 28, 2024
14 checks passed
@StAlKeR7779 StAlKeR7779 deleted the stalker7779/modular_t2i_adapter branch July 28, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend PRs that change backend files invocations PRs that change invocations python PRs that change python files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants