-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modular backend - T2I Adapter #6662
Merged
RyanJDick
merged 3 commits into
invoke-ai:main
from
StAlKeR7779:stalker7779/modular_t2i_adapter
Jul 28, 2024
Merged
Modular backend - T2I Adapter #6662
RyanJDick
merged 3 commits into
invoke-ai:main
from
StAlKeR7779:stalker7779/modular_t2i_adapter
Jul 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StAlKeR7779
requested review from
lstein,
blessedcoolant,
brandonrising,
RyanJDick,
hipsterusername and
psychedelicious
as code owners
July 23, 2024 23:59
github-actions
bot
added
python
PRs that change python files
invocations
PRs that change invocations
backend
PRs that change backend files
labels
Jul 23, 2024
RyanJDick
reviewed
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor comments.
Manual tests to be completed before merging (I've completed a few already.):
- SDXL, Standard guidance, single T2I-Adapter
- SDXL, Standard guidance, multiple T2I-Adapters
- SDXL, Sequential guidance, single T2I-Adapter
- SDXL, Sequential guidance, multiple T2I-Adapters
At leat one test with SD1 to make sure that both SDXL and SD1 are working: - SD1, Standard guidance, single T2I-Adapter
Tried:
|
Co-Authored-By: Ryan Dick <[email protected]>
RyanJDick
approved these changes
Jul 26, 2024
hipsterusername
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
PRs that change backend files
invocations
PRs that change invocations
python
PRs that change python files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
T2I Adapter code from #6577.
Related Issues / Discussions
#6606
https://invokeai.notion.site/Modular-Stable-Diffusion-Backend-Design-Document-e8952daab5d5472faecdc4a72d377b0d
QA Instructions
Run with and without set
USE_MODULAR_DENOISE
environment.Merge Plan
Nope.
If you think that there should be some kind of tests - feel free to add.
Checklist