feat: support mark any underscore module as private #618
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
If I have a lot of internal files that wanted to be share across multiple entries, e.g.
_internal/**
and each entry randomly imports the internal files, we could create some shared chunks for_internal/**
so that each shared module will have a new chunk.For example
In the dependency graph,
entry-a
importsutil-a
, andentry-b
importsutil-b
. we could just create 2 chunks for_internal/util-a
and_internal/util-b
instead of asking users to use a barrel file like_internal/index.ts
or rename everything under_internal
with a underscore prefix.Closes #617