feat: support mark any underscore module as private (#618)

src/constants.ts

@@ -82,3 +82,5 @@ export const DEFAULT_TS_CONFIG = {
 }
 
 export const BINARY_TAG = '$binary'
+
+export const PRIVATE_GLOB_PATTERN = '**/_*/**'

src/entries.ts

@@ -20,6 +20,7 @@ import {
   SRC,
   runtimeExportConventions,
   specialExportConventions,
+  PRIVATE_GLOB_PATTERN,
 } from './constants'
 import { posixRelativify } from './lib/format'
 
@@ -300,7 +301,7 @@ export async function collectSourceEntriesByExportPath(
   const files = await glob(globalPatterns, {
     cwd: dirPath,
     nodir: true,
-    ignore: '**/_*',
+    ignore: PRIVATE_GLOB_PATTERN,
   })
 
   for (const file of files) {
@@ -390,14 +391,12 @@ export async function collectSourceEntriesFromExportPaths(
   }
 
   // Search private shared module files which are not in the parsedExportsInfo, but start with _.
-  // e.g. _utils.ts, _utils/index.ts
-  // e.g. _utils.development.ts, _utils/index.development.js
-  const privatePattern = [
-    `**/_*{,/index}.{${[...availableExtensions].join(',')}}`,
-    `**/_*{,/index}.{${[...runtimeExportConventions].join(',')}}.{${[
-      ...availableExtensions,
-    ].join(',')}}`,
-  ]
+  // Leading underscore: e.g. _utils.ts, _utils/index.ts
+  // Segment contains leading underscore: e.g. a/_b/_c.ts, a/b/_c/index.ts
+  // Contains special suffix: e.g. _utils.development.ts, _utils/index.development.js
+  const suffixPattern = [...runtimeExportConventions].join(',')
+  const extPattern = [...availableExtensions].join(',')
+  const privatePattern = `**/_*{,/*}{,{.${suffixPattern}}}.{${extPattern}}`
   const privateFiles = await glob(privatePattern, {
     cwd: sourceFolderPath,
     nodir: true,
@@ -419,6 +418,7 @@ export async function collectSourceEntriesFromExportPaths(
 
     // Map private shared files to the dist directory
     // e.g. ./_utils.ts -> ./dist/_utils.js
+    // TODO: improve the logic to only generate the required files, not all possible files
     const privateExportInfo: [string, string][] = [
       [
         posixRelativify(

src/prepare/prepare-entries.ts

@@ -1,6 +1,10 @@
 import { existsSync } from 'fs'
 import { glob } from 'glob'
-import { BINARY_TAG, availableExtensions } from '../constants'
+import {
+  BINARY_TAG,
+  PRIVATE_GLOB_PATTERN,
+  availableExtensions,
+} from '../constants'
 
 import { collectSourceEntriesByExportPath } from '../entries'
 import { normalizePath, sourceFilenameToExportFullPath } from '../utils'
@@ -24,13 +28,13 @@ export async function collectSourceEntries(sourceFolderPath: string) {
   const binMatches = await glob(binPattern, {
     cwd: sourceFolderPath,
     nodir: true,
-    ignore: '**/_*', // ignore private entries
+    ignore: PRIVATE_GLOB_PATTERN, // ignore private entries
   })
 
   const srcMatches = await glob(srcPattern, {
     cwd: sourceFolderPath,
     nodir: true,
-    ignore: '**/_*', // ignore private entries
+    ignore: PRIVATE_GLOB_PATTERN, // ignore private entries
   })
 
   for (const file of binMatches) {

test/integration/shared-any-module/index.test.ts

@@ -0,0 +1,35 @@
+import {
+  assertFilesContent,
+  createIntegrationTest,
+  getFileNamesFromDirectory,
+} from '../utils'
+
+describe('integration shared-module', () => {
+  it('should split all shared module into different chunks', async () => {
+    await createIntegrationTest(
+      {
+        directory: __dirname,
+      },
+      async ({ distDir, stdout }) => {
+        const jsFiles = await getFileNamesFromDirectory(distDir)
+        expect(jsFiles).toEqual([
+          '_internal/util-a.cjs',
+          '_internal/util-a.js',
+          '_internal/util-b.cjs',
+          '_internal/util-b.js',
+          'export-a.js',
+          'export-b.js',
+          'export-c.js',
+          'private/_nested/util-c.cjs',
+          'private/_nested/util-c.js',
+        ])
+
+        await assertFilesContent(distDir, {
+          'export-a.js': `'./_internal/util-a.js'`,
+          'export-b.js': `'./_internal/util-b.js'`,
+          'export-c.js': `'./private/_nested/util-c.js'`,
+        })
+      },
+    )
+  })
+})

test/integration/shared-any-module/package.json

@@ -0,0 +1,12 @@
+{
+  "name": "shared-module",
+  "type": "module",
+  "exports": {
+    "./export-a": "./dist/export-a.js",
+    "./export-b": "./dist/export-b.js",
+    "./export-c": "./dist/export-c.js"
+  },
+  "dependencies": {
+    "react": "*"
+  }
+}

test/integration/shared-any-module/src/_internal/util-a.js

@@ -0,0 +1 @@
+export const utilA = 'utilA'

test/integration/shared-any-module/src/_internal/util-b.js

@@ -0,0 +1 @@
+export const utilB = 'utilB'

test/integration/shared-any-module/src/export-a.js

@@ -0,0 +1,6 @@
+import { utilA } from './_internal/util-a'
+import { utilB } from './_internal/util-b'
+
+export const getName = () => {
+  return 'export-a' + utilA + utilB
+}

test/integration/shared-any-module/src/export-b.js

@@ -0,0 +1,6 @@
+import { utilB } from './_internal/util-b'
+import { utilC } from './private/_nested/util-c'
+
+export const getName = () => {
+  return 'export-b' + utilB + utilC
+}

test/integration/shared-any-module/src/export-c.js

@@ -0,0 +1,6 @@
+import { utilA } from './_internal/util-a'
+import { utilC } from './private/_nested/util-c'
+
+export const getName = () => {
+  return 'export-c' + utilA + utilC
+}

test/integration/shared-any-module/src/private/_nested/util-c.js

@@ -0,0 +1 @@
+export const utilC = 'utilC'