-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow additional floor types #332
Conversation
Some additional thoughts (#327 (review)):
|
Note that "SIP" stands for Structural Insulated Panel, as opposed to "structurally". If feasible, I suggest eliminating the "ly" part of the FloorType label. |
…FloorType element that references the new FloorType data type. Remove dumb annotations.
Thanks @RockyMtnBrian, I have fixed this. Because that name was already used for I also discovered that @bpark1327 had added a new data type for floor type, but didn't actually add a FloorType element under Floor that uses it. That's now fixed too. |
Just a thought, @shorowit: If there's a need to separately label the SIP wall vs SIP floor, then SIPWall and SIPFloor might do the job. |
Note that SIPs get used for roofs, too. SIPRoof? |
@RockyMtnBrian There is not a need to distinguish SIP wall from SIP floor -- one will show up as For roofs, it looks like the best place to add a SIP option under Roof would be in the DeckType element. (RoofType would be most consistent with WallType and FloorType, but unfortunately it's already used to describe the roofing material.) |
Fixes #321
Renames
FrameFloors/FrameFloor
toFloors/Floor
.Renames
WallType/StructurallyInsulatedPanel
toWallType/StructuralInsulatedPanel
Adds
FloorType
with choices of:WoodFrame
StructuralInsulatedPanel
SteelFrame
SolidConcrete
Other