Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More HPXML v4 updates #69

Merged
merged 7 commits into from
Jan 30, 2023
Merged

More HPXML v4 updates #69

merged 7 commits into from
Jan 30, 2023

Conversation

shorowit
Copy link
Collaborator

@shorowit shorowit commented Nov 10, 2022 •
edited
Loading

@shorowit shorowit self-assigned this Nov 10, 2022
@NREL NREL deleted a comment from github-actions bot Jan 27, 2023
@github-actions
Copy link

File Coverage Missing
All files 98% ✅
__init__.py 100% ✅
converter.py 98% ✅ 325 386 493 647-648 884-885
exceptions.py 100% ✅

Minimum allowed coverage is 98%

Generated by 🐒 cobertura-action against be5eb1f

@shorowit shorowit marked this pull request as ready for review January 30, 2023 17:04
@shorowit shorowit requested a review from nmerket January 30, 2023 17:04
nmerket
nmerket approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@nmerket nmerket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@nmerket nmerket merged commit 033fdbb into main Jan 30, 2023
@nmerket nmerket deleted the hpxml_v4c branch January 30, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerket nmerket nmerket approved these changes

Assignees

@shorowit shorowit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shorowit @nmerket