Allow snapshot strategy to be configured #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trotzig
force-pushed
the
clip-strategy
branch
from
1633592 to
4f9be08
Compare
|
Docs: happo/docs#93 |
lencioni
force-pushed
the
clip-strategy
branch
2 times, most recently
from
575d330 to
6a0f6c5
Compare
lencioni
reviewed
Jan 21, 2025
lencioni
force-pushed
the
clip-strategy
branch
from
6a0f6c5 to
5602c51
Compare
We want people to be able to use the new "clip" snapshot strategy that happo-e2e has made available. The clip strategy means the whole dom is included in the snapshot, and happo workers will clip the screenshot based on where the `[data-happo-clip]` element is located.
lencioni
force-pushed
the
clip-strategy
branch
from
5602c51 to
f2e55a4
Compare
lencioni
added a commit
to happo/happo-playwright
that referenced
this pull request
Jan 24, 2025
This matches the `snapshotStrategy` option we recently added to happo-cypress: happo/happo-cypress#122 The clip strategy means the whole DOM is included in the snapshot, and happo workers will clip the screenshot based on where the `[data-happo-clip]` element is located. This data attribute is added by happo-e2e when using the clip snapshot strategy: happo/happo-e2e#54
lencioni
added a commit
to happo/happo-playwright
that referenced
this pull request
Jan 24, 2025
This matches the `snapshotStrategy` option we recently added to happo-cypress: happo/happo-cypress#122 The clip strategy means the whole DOM is included in the snapshot, and happo workers will clip the screenshot based on where the `[data-happo-clip]` element is located. This data attribute is added by happo-e2e when using the clip snapshot strategy: happo/happo-e2e#54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
localSnapshots: true, we want people to be able to use the new "clip" snapshot strategy that happo-e2e has made available.https://docs.happo.io/docs/cypress#locally-produced-images
The clip strategy means the whole dom is included in the snapshot, and happo workers will clip the screenshot based on where the
[data-happo-clip]element is located.