Allow snapshot strategy to be configured #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the `snapshotStrategy` option we recently added to happo-cypress: happo/happo-cypress#122 The clip strategy means the whole DOM is included in the snapshot, and happo workers will clip the screenshot based on where the `[data-happo-clip]` element is located. This data attribute is added by happo-e2e when using the clip snapshot strategy: happo/happo-e2e#54
lencioni
force-pushed
the
snapshot-strategy-clip
branch
from
286b994 to
dc57eeb
Compare
trotzig
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the
snapshotStrategyoption we recently added to happo-cypress:happo/happo-cypress#122
The clip strategy means the whole DOM is included in the snapshot, and happo workers will clip the screenshot based on where the
[data-happo-clip]element is located. This data attribute is added by happo-e2e when using the clip snapshot strategy:happo/happo-e2e#54