Remove REPL mode from ssm-scala #462
Open
+4
−211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mode of execution was added very early in ssm-scala's life and has never been properly supported or maintained. A cursory experiment suggests this feature is currently broken. The only feature REPL mode offers over and above the standard ssh mode is the ability to run commands on multiple instances at once, but in the modern world I wouldn't expect us to be taking this approach to instance management.
adamnfish
force-pushed
the
remove-repl-mode
branch
from
b7a85c4 to
58e42e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Removes REPL mode support.
What is the value of this?
This mode of execution was added very early in ssm-scala's life and has never been properly supported or maintained. A cursory experiment suggests this feature is currently broken. The feature brings in additional dependencies, and adds weight too our codebase, so we should remove it if it isn't being used.
The only feature REPL mode offers over and above the standard ssh mode is the ability to run commands on multiple instances at once, but in the modern world I wouldn't expect us to be taking this approach to instance management.