Scalafmt and compiler warning fixes #464
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies the implementation of the instance resolution logic, to address an incomplete match warning. Other compiler warnings are mostly about Scala 2.x -> 3.x changes, and have been fixed. A few deprecation warnings remain relating to the AWS v1 SDK (specifically, the use of `Regions`). The v1 SDK will shortly be replaced with the supported v2 Java SDK, so we can leave these for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this PR is currently based on the remove-repl-mode PR, since there's no need to fix issues with code that is being removed.
What does this change?
This is just about tidying things up ahead of future changes.
Introduces scalafmt into the codebase, to stop us having to think about how things are formatted. We also address the compiler warnings in the project.
What is the value of this?
Tidies things up ahead of updating the AWS Java SDK to v2.
Any additional notes?
The PR simplifies the implementation of the instance resolution logic, to address an incomplete match warning. Other compiler warnings are mostly about Scala 2.x -> 3.x changes, and have been fixed.
A few deprecation warnings remain relating to the AWS v1 SDK (specifically, the use of
Regions). The v1 SDK will shortly be replaced with the supported v2 Java SDK, so we can leave these for now.