drawing utils #27
Merged
drawing utils #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pckroon
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Nice work, I do have a few comments though.
Besides those, consider which functions are helper functions (or even complete modules) that should not be user exposed, and prefix those with a _.
As I see it there are 2 that need to be user accessible: draw_molecule, and vsepr_layout
|
Oh, one more note, do you want tests for this? |
pckroon
requested changes
Oct 29, 2024
pckroon
requested changes
Dec 4, 2024
Open
Suggestions by Peter Co-authored-by: Peter C Kroon <[email protected]>
new code generating triplets Co-authored-by: Peter C Kroon <[email protected]>
pckroon
requested changes
Dec 12, 2024
Co-authored-by: Peter C Kroon <[email protected]>
pckroon
approved these changes
Dec 12, 2024
Co-authored-by: Peter C Kroon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.