Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawing MAINT #36

Open
fgrunewald opened this issue Dec 3, 2024 · 2 comments
Open

Drawing MAINT #36

fgrunewald opened this issue Dec 3, 2024 · 2 comments

Comments

@fgrunewald
Copy link
Collaborator

  • I have the feeling this gets significantly simpler if you create a list relevant_neighbors containing (angle, node_idx, color). If you reverse sort that (reverse, because plt.pie is counterclockwise starting at the x-axis) and iterate you can populate slices? startangle is then something like sorted_neighbors[0][0]/2. Maybe.
    Also, use weights; plt.pie normalizes

  • E**2 is kind of painful. Probably /way/ more efficient to iterate over nodes with degree>1 and doing an itertools.combinations on their neighbours

@pckroon
Copy link
Collaborator

pckroon commented Dec 4, 2024

Details can be found in #27

@fgrunewald
Copy link
Collaborator Author

change in node pies to account for more than one resid; multi squash

   neigh_ids = [nid in fragids for nid in graph.nodes[neigh]['fragid']]
+                if any(neigh_ids):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants