Run part of LB tests on Dualstack cluster #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuanWang-Amos
approved these changes
Sep 10, 2024
|
Please merge this after both staging and prod is working. |
|
@aranjans can you add the links to adhoc kokoro run against this branch. Let's run the dualstack test suite and lb test suite both and attach here |
|
@purnesh42H its already added as part of the description for dualstack. |
|
Looks like our intention is to add those tests to dual stack while keep the original ones, can you add back those tests to LB? |
|
@XuanWang-Amos Reverted back the changes for LB tests. |
sergiitk
reviewed
Sep 11, 2024
| ) | ||
| # master-only tests | ||
| if [[ "${TESTING_VERSION}" =~ "master" ]]; then |
There was a problem hiding this comment.
no need to run bootstrap_generator_test and subsetting_test
aranjans
added a commit
that referenced
this pull request
Sep 18, 2024
Reverting part of [this](#130) commit, as `remove_neg_test` is causing failure in dualstack test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables some of the LB tests to run on dualstack cluster.
Logs from local run are available here.