Exclude remove_neg_test from Dualstack test suite #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aranjans
requested review from
sergiitk and
XuanWang-Amos
and removed request for
sergiitk
|
@aranjans can you mention the previous PR in description and reason for doing this change? |
purnesh42H
approved these changes
Sep 18, 2024
XuanWang-Amos
approved these changes
Sep 18, 2024
XuanWang-Amos
added a commit
that referenced
this pull request
Oct 22, 2024
This reverts commit 37bd824.
3 tasks
XuanWang-Amos
added a commit
that referenced
this pull request
Oct 23, 2024
Reverts #133 We removed `test_remove_neg` from tests because we're seeing an issue where healthy endpoints were not present in EDS response, looks like the issue was fixed somehow, this case passed in the following manual runs: - [x] [grpc/java/v1.67.x/branch/psm-dualstack](https://source.cloud.google.com/results/invocations/ca676ade-7488-4b1a-b968-d20c55e28a3c) - [x] [grpc/java/master/branch/psm-dualstack](https://source.cloud.google.com/results/invocations/63b7dc55-fa18-412e-9e3a-44c97a127a19) - [x] [grpc/core/master/linux/psm-dualstack](https://source.cloud.google.com/results/invocations/6c0b252c-9e67-4aa5-8cd8-1b3500a14a3a) I guess it's time for us to add back this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting part of this commit, as
remove_neg_testis causing failure in dualstack test suite.