-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add network_latency_ms field to ALTS's NextHandshakeMessageReq. #138
Add network_latency_ms field to ALTS's NextHandshakeMessageReq. #138
Conversation
(FWIW, it tends to be useful to copy the CL number here so we can follow things a bit easier. Especially further in the future and trying to figure out what we did.) |
Sure thing, done. :) |
|
It's not a big deal in this case, because I only care about the positive values anyway, so "zero" and "not set" are equivalent. If there's an easy fix to allow |
Thanks for the offer, but I think I have it. We're going to need to merge #123 and then bumping past 21.x required a non-obvious line and bumping to 25 required further changes to bazel. I've fought this before in other circumstances. |
Thanks Eric! |
Already internally-reviewed (see cl/589894002 and cl/589974172).