Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alts: Record network latency and pass it to the handshaker service. #6851

Merged
merged 5 commits into from
Dec 15, 2023

Conversation

matthewstevenson88
Copy link
Contributor

@matthewstevenson88 matthewstevenson88 commented Dec 12, 2023

The corresponding field was added to the proto in grpc/grpc-proto#138.

@cesarghali Could you give me a quick gut check on whether this looks reasonable to you?

RELEASE NOTES: none

@matthewstevenson88 matthewstevenson88 added the Type: Feature New features or improvements in behavior label Dec 12, 2023
@matthewstevenson88 matthewstevenson88 added this to the 1.61 Release milestone Dec 12, 2023
@matthewstevenson88 matthewstevenson88 self-assigned this Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #6851 (366f3ab) into master (45624f0) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6851      +/-   ##
==========================================
+ Coverage   83.64%   83.76%   +0.12%     
==========================================
  Files         286      286              
  Lines       30786    30792       +6     
==========================================
+ Hits        25750    25793      +43     
+ Misses       3977     3944      -33     
+ Partials     1059     1055       -4     
Files Coverage Δ
credentials/alts/internal/handshaker/handshaker.go 74.22% <100.00%> (+0.82%) ⬆️

... and 14 files with indirect coverage changes

@easwars
Copy link
Contributor

easwars commented Dec 13, 2023

@matthewstevenson88: Any reason this is in draft? Is this good to be looked at?

@matthewstevenson88
Copy link
Contributor Author

Sorry for the delayed reply, busy week. :)

I just wanted a chance to fix up the vet-proto issues caused by me using an old version of the protoc tool. Should be all fixed now.

@easwars Would you be able to review?

@matthewstevenson88 matthewstevenson88 marked this pull request as ready for review December 14, 2023 19:47
@easwars
Copy link
Contributor

easwars commented Dec 15, 2023

I can do a pass for Go readability related stuff. But I don't know enough to review for correctness etc.

@matthewstevenson88
Copy link
Contributor Author

Thanks @easwars. Added @cesarghali to take a first look.

@matthewstevenson88
Copy link
Contributor Author

@easwars Would you mind taking a quick pass for readability now?

Copy link
Contributor

@easwars easwars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo minor nits.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change covered under #6857?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, sync-ed this branch.

credentials/alts/internal/testutil/testutil.go Outdated Show resolved Hide resolved
@matthewstevenson88
Copy link
Contributor Author

Thanks for the review @easwars!

@matthewstevenson88 matthewstevenson88 merged commit 444749d into grpc:master Dec 15, 2023
14 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants