handle demangling OSX names with underscore prefix #924
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalexand
reviewed
Jan 23, 2025
| // OSX has all the symbols prefixed with extra '_' so lets try | ||
| // once more without it | ||
| if strings.HasPrefix(fn.SystemName, "_") { | ||
| if demangled := demangle.Filter(fn.SystemName[1:], o...); demangled != fn.SystemName { |
There was a problem hiding this comment.
Could we just pass strings.StripPrefix(fn.SystemName, "_"), ... in the demangle.Filter call above?
There was a problem hiding this comment.
Above? So just cut all the time no matter OS and everything? Then it won't work, since _ is usually used for mangled names for regular OS-es. And cutting it will simply break everything.
There was a problem hiding this comment.
Oh, got it.
Can we add a test that will exercise this code path?
Updates github ticket google#477
alk
force-pushed
the
osx-un-underscore
branch
from
7dd4dbb to
85c67d0
Compare
aalexand
approved these changes
Jan 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #924 +/- ##
==========================================
+ Coverage 66.86% 66.96% +0.09%
==========================================
Files 44 44
Lines 9824 9864 +40
==========================================
+ Hits 6569 6605 +36
- Misses 2794 2820 +26
+ Partials 461 439 -22 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion at #477 (comment)