handle demangling OSX names with underscore prefix

Updates github ticket #477
google · Jan 23, 2025 · 7dd4dbb · 7dd4dbb
1 parent 997b0b7
commit 7dd4dbb
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/internal/symbolizer/symbolizer.go b/internal/symbolizer/symbolizer.go
@@ -292,6 +292,16 @@ func demangleSingleFunction(fn *profile.Function, options []demangle.Option) {
 		fn.Name = demangled
 		return
 	}
+
+	// OSX has all the symbols prefixed with extra '_' so lets try
+	// once more without it
+	if strings.HasPrefix(fn.SystemName, "_") {
+		if demangled := demangle.Filter(fn.SystemName[1:], o...); demangled != fn.SystemName {
+			fn.Name = demangled
+			return
+		}
+	}
+
 	// Could not demangle. Apply heuristics in case the name is
 	// already demangled.
 	name := fn.SystemName