-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support thingy91x #18
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szczys
force-pushed
the
szczys/add-support-thingy91x
branch
from
December 16, 2024 23:57
27c730f
to
d93bc1f
Compare
MarkoPura
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Add the same testing for a Golioth connection that is used in the RD template before trying to stream data to Golioth. Signed-off-by: Mike Szczys <[email protected]>
- Add socs/nrf9160_ns.conf to track all SoC specific configuration - Move board specific configuration from prj.conf to boards/thingy91_nrf9160_ns.conf Signed-off-by: Mike Szczys <[email protected]>
Use CONFIG_SOC_SERIES_NRF91X with #if so both the nrf9160 and nrf9151 will cause the code to build. Signed-off-by: Mike Szczys <[email protected]>
Allow bsim drivers to be installed by west update. These are necessary for the bme688 on the Thingy91x. Signed-off-by: Mike Szczys <[email protected]>
This application uses PWM to control all of the LEDs. Remove golioth_led and user_led as they are not present. Remove unused devicetree entries for click-uart and click-i2c. Signed-off-by: Mike Szczys <[email protected]>
Add Kconfig and Devicetree files necessary to support the Thingy91x. Signed-off-by: Mike Szczys <[email protected]>
Add conditionals to handle sensor variations between the Thingy91 and the Thingy91x. Known issues: the iaq/co2/voc readings for the BME68x on the Thingy91 don't appear to ever change. However, this is the same behavior observed for the factory firmware of the Thingy91x so it is being added for now. Signed-off-by: Mike Szczys <[email protected]>
- Add test and release builds for the thingy91x - Install `ecdsa` python package as thingy91x build depends on it but requirements.txt doesn't install it. Signed-off-by: Mike Szczys <[email protected]>
szczys
force-pushed
the
szczys/add-support-thingy91x
branch
from
December 18, 2024 16:48
d93bc1f
to
395dc46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/golioth/devrel-issue-tracker/issues/505